allow array relation connection fields regardless of aggregation permission & change relay endpoint to '/v1beta1/relay' (fix #5218) #5257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit 8c761ee |
Contributor
|
Review app for commit b3adcb5 deployed to Heroku: https://hge-ci-pull-5257.herokuapp.com |
marionschleifer
approved these changes
Jul 1, 2020
b3adcb5 to
a47b5ac
Compare
Contributor
|
Review app for commit a47b5ac deployed to Heroku: https://hge-ci-pull-5257.herokuapp.com |
0x777
approved these changes
Jul 2, 2020
Contributor
|
Review app for commit 8c761ee deployed to Heroku: https://hge-ci-pull-5257.herokuapp.com |
Contributor
|
Review app https://hge-ci-pull-5257.herokuapp.com is deleted |
stevefan1999-personal
pushed a commit
to stevefan1999-personal/graphql-engine
that referenced
this pull request
Sep 12, 2020
…ission & change relay endpoint to '/v1beta1/relay' (fix hasura#5218) (hasura#5257) * fix error when array relation connections are queried, fix hasura#5218 * change relay endpoint to '/v1beta1/relay' * Update CHANGELOG.md Co-authored-by: Tirumarai Selvan <tiru@hasura.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial decision was to discard the array connection fields if aggregations aren't enabled in the select permission. It was because, the connection may have support for querying "aggregate" field in future iteration. In this PR, the change is made to include the connection field regardless of aggregation permission. However, if we were to support the "aggregate" field in the connection object, we can alone include that field only if aggregations are allowed.
Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR. If no changelog is required, then add theno-changelog-requiredlabel.No changelog entry is being added. The existing change log is modified to replace /v1beta/relay in place of /v1/relay.
Affected components
Related Issues
Fix #5218
Solution and Design
A single line change to include the array connection field regardless of
allowAggcheck.Steps to test and verify
Limitations, known bugs & workarounds
Server checklist
Catalog upgrade
Does this PR change Hasura Catalog version?
Metadata
Does this PR add a new Metadata feature?
GraphQL
Breaking changes
/v1beta1/relay.