这是indexloc提供的服务，不要输入任何密码
Skip to content

console: fix regression in editing permissions manually (fix #4683) (#4826) #4826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 4, 2020
Merged

console: fix regression in editing permissions manually (fix #4683) (#4826) #4826

merged 11 commits into from
Jun 4, 2020

Conversation

@soorajshankar
Copy link
Member

@soorajshankar soorajshankar commented May 20, 2020 •
edited by beerose
Loading

console: editing permissions manually seems to have stopped working properly

Description

Raw son edit on permissions was letting the user edit the entire JSON, Now user can fully edit the JSON rule.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

close #4683

Solution and Design

Removed editor level isJSON check.
Added denounce for editor onchange event. this will prevent unwanted event triggers.
Component separation for JSON editor, Permission Buttons etc.

Steps to test and verify

  1. Go to the Data module
  2. Select a table
  3. Go to Permissions tab
  4. Try to edit a Row select permissions
  5. Try editing the JSON.
  • Expected O/P

captured

@soorajshankar soorajshankar added the c/console Related to console label May 20, 2020
@soorajshankar soorajshankar requested review from beerose and rikinsk May 20, 2020 14:42
@soorajshankar soorajshankar requested review from a team as code owners May 20, 2020 14:42
@soorajshankar soorajshankar self-assigned this May 20, 2020
@netlify
Copy link

netlify bot commented May 20, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit b22ef4c

https://deploy-preview-4826--hasura-docs.netlify.app

@hasura-bot
Copy link
Contributor

hasura-bot commented May 20, 2020

Review app for commit 9dec0c3 deployed to Heroku: https://hge-ci-pull-4826.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4826-9dec0c3f

@hasura-bot
Copy link
Contributor

hasura-bot commented May 26, 2020

Review app for commit 6d9b92a deployed to Heroku: https://hge-ci-pull-4826.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4826-6d9b92ac

rikinsk
rikinsk approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@rikinsk rikinsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX approved

@rikinsk rikinsk assigned beerose and unassigned soorajshankar and rikinsk May 29, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented May 29, 2020

Review app for commit 6630537 deployed to Heroku: https://hge-ci-pull-4826.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4826-66305378

beerose
beerose suggested changes May 31, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. It's good that we're unloading console/src/components/Services/Data/TablePermissions/Permissions.js 😉

soorajshankar and others added 2 commits June 1, 2020 12:17
@soorajshankar
Update console/src/components/Services/Data/TablePermissions/JSONEdit…
2309742 
…or.tsx

Co-authored-by: Aleksandra Sikora <ola.zxcvbnm@gmail.com>
@soorajshankar
review comments
2d137d7
@beerose beerose assigned soorajshankar and beerose and unassigned beerose and soorajshankar Jun 1, 2020
@soorajshankar soorajshankar requested a review from beerose June 3, 2020 09:44
beerose
beerose suggested changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change molecules to components and possibly put there also other files like JSONEditor? It's a bit confusing name, and we stick to nested components directory in other places.

Actually, in those cases, we can even have a flat files structure.

@beerose beerose assigned kolharsam and soorajshankar and unassigned beerose and kolharsam Jun 3, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 4, 2020

Review app for commit 67e6e1e deployed to Heroku: https://hge-ci-pull-4826.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4826-67e6e1ed

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 4, 2020

Review app for commit be93048 deployed to Heroku: https://hge-ci-pull-4826.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4826-be93048a

@rikinsk rikinsk changed the title console: editing permissions manually seems to have stopped working properly console: fix regression in editing permissions manually (fix #4683) (#4826) Jun 4, 2020
@rikinsk rikinsk merged commit 1b3f5b8 into hasura:master Jun 4, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 4, 2020

Review app https://hge-ci-pull-4826.herokuapp.com is deleted

beerose pushed a commit to beerose/graphql-engine that referenced this pull request Jun 16, 2020
@soorajshankar
console: fix regression in editing permissions manually (fix hasura#4683
8446d80 
) (hasura#4826)
@beerose beerose mentioned this pull request Jun 16, 2020
Merged
1 task
rikinsk pushed a commit that referenced this pull request Jun 16, 2020
console: misc bug fixes (#4669, #4673, #4682, #4826, #5016, #4877 ) (#…
ece895f 
…5108)

* console: fix checkbox for forwarding client headers in actions (close #4595) (#4669)
* console: fix bulk selected rows state in data browser (close #4654) (#4673)
* console: fix displaying boolean values in Edit Row tab (#4682)
* console: fix regression in editing permissions manually (fix #4683) (#4826)
* console: fix "Cannot read property 'foldable'" runtime error in `Browse Rows` page (fix #4907) (#5016)
* console: fix enum tables reload data button UI (close #4647) (#4877)
stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@soorajshankar @stevefan1999-personal
console: fix regression in editing permissions manually (fix hasura#4683
14fcd57 
) (hasura#4826)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soorajshankar soorajshankar

Labels

c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

console: editing permissions manually seems to have stopped working properly

5 participants

@soorajshankar @hasura-bot @beerose @rikinsk @kolharsam