这是indexloc提供的服务，不要输入任何密码
Skip to content

console: fix enum tables reload data button UI (close #4647) #4877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 9, 2020
Merged

console: fix enum tables reload data button UI (close #4647) #4877

merged 7 commits into from
Jun 9, 2020

Conversation

@soorajshankar
Copy link
Member

@soorajshankar soorajshankar commented May 25, 2020 •
edited
Loading

Description

Enum table reload button UI was buggy, fixed styling, and rendering logic.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

close #4647

Solution and Design

  • Reload all remote schemas checkbox is removed from the Data module.
  • Checkbox functionality was not working which is fixed in this PR.
  • Metadata modules will have reload button and the checkbox.

Steps to test and verify

  • Go to the data module and open an enum table.
  • match the UI in browse tab

image

- match UI in the insert tab

image

- match the UI from settings

image

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code

    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields

    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

@soorajshankar soorajshankar requested review from a team as code owners May 25, 2020 14:13
@netlify
Copy link

netlify bot commented May 25, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit f387fed

https://deploy-preview-4877--hasura-docs.netlify.app

@beerose beerose added the c/console Related to console label May 26, 2020
beerose
beerose suggested changes Jun 3, 2020
View reviewed changes
@beerose beerose assigned soorajshankar and rikinsk and unassigned beerose and rikinsk Jun 3, 2020
@soorajshankar soorajshankar requested review from a team as code owners June 5, 2020 10:16
@soorajshankar soorajshankar marked this pull request as draft June 5, 2020 10:17
@soorajshankar soorajshankar force-pushed the fix/enum-tables-reload-btn branch from f1ac2c6 to 60b8ba2 Compare June 5, 2020 10:23
@soorajshankar soorajshankar marked this pull request as ready for review June 5, 2020 10:24
rikinsk
rikinsk requested changes Jun 5, 2020
View reviewed changes
Copy link
Member

@rikinsk rikinsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soorajshankar I noticed you took some effort to customize the tooltip icon. This is actually something we want to make consistent across the code. So lets make the Tooltip icon as fa-info-circle and not make it customizable.

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 5, 2020

Review app for commit 6b5280c deployed to Heroku: https://hge-ci-pull-4877.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4877-6b5280c1

@soorajshankar soorajshankar self-assigned this Jun 9, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 9, 2020

Review app for commit c79f3f4 deployed to Heroku: https://hge-ci-pull-4877.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4877-c79f3f42

@soorajshankar soorajshankar requested a review from rikinsk June 9, 2020 12:51
@beerose beerose removed the request for review from a team June 9, 2020 12:57
@beerose beerose assigned rikinsk and unassigned soorajshankar Jun 9, 2020
@rikinsk rikinsk assigned beerose and unassigned rikinsk Jun 9, 2020
@beerose beerose changed the title fix/enum tables reload btn close #4647 console: fix enum tables reload data button UI (close #4647) Jun 9, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 9, 2020

Review app for commit 2ba8dfa deployed to Heroku: https://hge-ci-pull-4877.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4877-2ba8dfaf

@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 9, 2020

Review app for commit c05cb62 deployed to Heroku: https://hge-ci-pull-4877.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4877-c05cb621

@beerose beerose merged commit 2861bea into hasura:master Jun 9, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jun 9, 2020

Review app https://hge-ci-pull-4877.herokuapp.com is deleted

@soorajshankar soorajshankar deleted the fix/enum-tables-reload-btn branch June 9, 2020 16:53
beerose pushed a commit that referenced this pull request Jun 10, 2020
@soorajshankar
console: fix enum tables reload data button UI (close #4647) (#4877)
71e33c0
beerose pushed a commit to beerose/graphql-engine that referenced this pull request Jun 16, 2020
@soorajshankar
console: fix enum tables reload data button UI (close hasura#4647) (h…
c8a9145 
…asura#4877)
rikinsk pushed a commit that referenced this pull request Jun 16, 2020
console: misc bug fixes (#4669, #4673, #4682, #4826, #5016, #4877 ) (#…
ece895f 
…5108)

* console: fix checkbox for forwarding client headers in actions (close #4595) (#4669)
* console: fix bulk selected rows state in data browser (close #4654) (#4673)
* console: fix displaying boolean values in Edit Row tab (#4682)
* console: fix regression in editing permissions manually (fix #4683) (#4826)
* console: fix "Cannot read property 'foldable'" runtime error in `Browse Rows` page (fix #4907) (#5016)
* console: fix enum tables reload data button UI (close #4647) (#4877)
stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@soorajshankar @stevefan1999-personal
console: fix enum tables reload data button UI (close hasura#4647) (h…
98e2f66 
…asura#4877)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@beerose beerose

Labels

c/console Related to console

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

console: enum tables reload data UI is buggy

4 participants

@soorajshankar @hasura-bot @beerose @rikinsk