这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@rikinsk
Copy link
Member

@rikinsk rikinsk commented May 8, 2020

Description

#4599

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • install manifests

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@rikinsk rikinsk requested a review from a team as a code owner May 8, 2020 12:37
@rikinsk rikinsk added the c/deployment Related to deployment label May 8, 2020
@rikinsk rikinsk requested a review from shahidhk May 8, 2020 12:40
Copy link
Member

@shahidhk shahidhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manifests LGTM.

We need to add a note on dev mode to our production checklist. Can be done on this PR or another as well.

@netlify
Copy link

netlify bot commented May 22, 2020

Deploy preview for hasura-docs ready!

Built with commit 6f11000

https://deploy-preview-4716--hasura-docs.netlify.app

Copy link
Contributor

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog

@rikinsk rikinsk merged commit a69f47c into hasura:master Jun 3, 2020
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-4716.herokuapp.com is deleted

@rikinsk rikinsk deleted the install-manifests-enable-dev-mode branch June 3, 2020 09:55
stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/deployment Related to deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants