这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@beerose
Copy link
Contributor

@beerose beerose commented May 6, 2020

Description

Previously boolean values weren't loaded properly on the edit row view. This PR fixes it.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Console

@beerose beerose requested a review from a team as a code owner May 6, 2020 07:15
@beerose beerose requested a review from a team as a code owner May 6, 2020 07:19
@hasura-bot
Copy link
Contributor

Review app for commit 17bc98b deployed to Heroku: https://hge-ci-pull-4682.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4682-17bc98b6

@rikinsk rikinsk added the c/console Related to console label May 6, 2020
@beerose beerose requested a review from rikinsk May 6, 2020 09:24
Copy link
Member

@rikinsk rikinsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beerose This still doesnt seem to work if the boolean value is set to false

@netlify
Copy link

netlify bot commented May 14, 2020

Deploy preview for hasura-docs ready!

Built with commit 0929f25

https://deploy-preview-4682--hasura-docs.netlify.app

@beerose beerose requested a review from rikinsk May 14, 2020 20:52
@hasura-bot
Copy link
Contributor

Review app for commit 414ab00 deployed to Heroku: https://hge-ci-pull-4682.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4682-414ab00c

@rikinsk rikinsk requested a review from wawhal May 15, 2020 08:53
@rikinsk rikinsk assigned wawhal and unassigned rikinsk May 15, 2020
@rikinsk rikinsk merged commit 78aa346 into hasura:master May 15, 2020
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-4682.herokuapp.com is deleted

@beerose beerose deleted the fix/bool-select branch May 15, 2020 09:59
beerose pushed a commit to beerose/graphql-engine that referenced this pull request Jun 16, 2020
rikinsk pushed a commit that referenced this pull request Jun 16, 2020
…5108)

* console: fix checkbox for forwarding client headers in actions (close #4595) (#4669)
* console: fix bulk selected rows state in data browser (close #4654) (#4673)
* console: fix displaying boolean values in Edit Row tab (#4682)
* console: fix regression in editing permissions manually (fix #4683) (#4826)
* console: fix "Cannot read property 'foldable'" runtime error in `Browse Rows` page (fix #4907) (#5016)
* console: fix enum tables reload data button UI (close #4647) (#4877)
stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/console Related to console

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants