-
Notifications
You must be signed in to change notification settings - Fork 2.8k
console: fix casing in notifications (fix #4173) #4541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Beep boop! 🤖 Hey @Proger3228, thanks for your PR! One of my human friends will review this PR and get back to you as soon as possible. Stay awesome! 😎 |
|
|
|
Deploy preview for hasura-docs ready! Built with commit 81ac4a3 |
|
Review app for commit 81ac4a3 deployed to Heroku: https://hge-ci-pull-4541.herokuapp.com |
|
@hasura/hge-console-owners this issue is recently fixed in #4224 |
|
Review app for commit dc3115c deployed to Heroku: https://hge-ci-pull-4541.herokuapp.com |
|
@Proger3228 thank you very much for your PR! However, the issue was fixed in #4224. I'm therefore closing this PR. |
|
Review app https://hge-ci-pull-4541.herokuapp.com is deleted |
|
Beep boop! 🤖 Hey @Proger3228! Sorry that your PR wasn’t merged. Do take a look at any of the other open issues to see if you’d like to take something up! We’re around on Discord if you have any questions 😄 |
Description
I fixed casing in permissions notification messages
Changed from update Permissions to Update permissions (also with delete)
Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR.Affected components
Related Issues
#4173
Solution and Design
Capitalized values in object "permChangeTypes" and changed string in requestMessage in console/src/components/Services/Data/TablePermissions/Actions.js
Steps to test and verify
Check notification message by changing permissions
Limitations, known bugs & workarounds
Server checklist
Catalog upgrade
Does this PR change Hasura Catalog version?
Metadata
Does this PR add a new Metadata feature?
GraphQL
Breaking changes