这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@Proger3228
Copy link

@Proger3228 Proger3228 commented Apr 23, 2020

Description

I fixed casing in permissions notification messages
Changed from update Permissions to Update permissions (also with delete)

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Console

Related Issues

#4173

Solution and Design

Capitalized values in object "permChangeTypes" and changed string in requestMessage in console/src/components/Services/Data/TablePermissions/Actions.js

Steps to test and verify

Check notification message by changing permissions

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No

Metadata

Does this PR add a new Metadata feature?

  • No

GraphQL

  • No new GraphQL schema is generated

Breaking changes

  • No Breaking changes

@Proger3228 Proger3228 requested a review from a team as a code owner April 23, 2020 17:39
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @Proger3228, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@netlify
Copy link

netlify bot commented Apr 23, 2020

Deploy preview for hasura-docs ready!

Built with commit 81ac4a3

https://deploy-preview-4541--hasura-docs.netlify.app

@hasura-bot
Copy link
Contributor

Review app for commit 81ac4a3 deployed to Heroku: https://hge-ci-pull-4541.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4541-81ac4a35

@lastnamearya
Copy link
Member

@hasura/hge-console-owners this issue is recently fixed in #4224

@hasura-bot
Copy link
Contributor

Review app for commit dc3115c deployed to Heroku: https://hge-ci-pull-4541.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4541-dc3115c9

@beerose
Copy link
Contributor

beerose commented Jun 6, 2020

@Proger3228 thank you very much for your PR!

However, the issue was fixed in #4224. I'm therefore closing this PR.

@beerose beerose closed this Jun 6, 2020
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-4541.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @Proger3228!

Sorry that your PR wasn’t merged.

Do take a look at any of the other open issues to see if you’d like to take something up! We’re around on Discord if you have any questions 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants