console: migrate WarningSymbol and TextInput to TypeScript #4314 #4562
Conversation
|
Beep boop! 🤖 Hey @fkhadra, thanks for your PR! One of my human friends will review this PR and get back to you as soon as possible. Stay awesome! 😎 |
|
Review app for commit 3ffd81c deployed to Heroku: https://hge-ci-pull-4562.herokuapp.com |
beerose
left a comment
There was a problem hiding this comment.
Perfect 🎉
Left one comment.
| const WarningSymbol = ({ | ||
| export interface WarningSymbolProps { | ||
| tooltipText: string; | ||
| tooltipPlacement?: string; |
There was a problem hiding this comment.
We can narrow it to 'left' | 'right' | 'top' | 'bottom'.
There was a problem hiding this comment.
Fixed. Thanks for the review 🙏
|
Review app for commit aaf50da deployed to Heroku: https://hge-ci-pull-4562.herokuapp.com |
|
Review app for commit 7143546 deployed to Heroku: https://hge-ci-pull-4562.herokuapp.com |
|
Review app for commit 55540e8 deployed to Heroku: https://hge-ci-pull-4562.herokuapp.com |
|
Beep boop! 🤖 Awesome work @fkhadra! All of us at Hasura ❤️ what you did. Thanks again 🤗 |
|
Review app https://hge-ci-pull-4562.herokuapp.com is deleted |
Description
Hey,
This PR migrates
WarningSymbolandTextInputto TypeScript. For the typing ofreact-bootstrap/lib/OverlayTrigger, I simply declared the module in thedeclaration.d.tsfile, the same as it's done forreact-bootstrap/lib/OverlayTooltip.I did not copy any types from DefinitelyTyped because this PR will bump the version of
react-bootstrapand add the typing as well.Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR.Affected components
Related Issues
Related issue #4314.
Catalog upgrade
Does this PR change Hasura Catalog version?
Metadata
Does this PR add a new Metadata feature?
GraphQL
Breaking changes