这是indexloc提供的服务，不要输入任何密码
Skip to content

Migrated Common/Modal to Typescript #4532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 14, 2020
Merged

Migrated Common/Modal to Typescript #4532

merged 6 commits into from
May 14, 2020

Conversation

@irshadjsr21
Copy link
Contributor

@irshadjsr21 irshadjsr21 commented Apr 23, 2020 •
edited
Loading

Description

Migrated Modal component to TypeScript.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

Related issue #4314.

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes
  • There are breaking changes:

@irshadjsr21 irshadjsr21 requested a review from a team as a code owner April 23, 2020 12:24
@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 23, 2020

Beep boop! 🤖

Hey @irshadjsr21, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@CLAassistant
Copy link

CLAassistant commented Apr 23, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 23, 2020

Review app for commit abac98c deployed to Heroku: https://hge-ci-pull-4532.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4532-abac98c6

@beerose beerose self-assigned this Apr 23, 2020
beerose
beerose suggested changes Apr 24, 2020
View reviewed changes
@fkhadra fkhadra mentioned this pull request Apr 25, 2020
Merged
7 tasks
@irshadjsr21
Copy link
Contributor Author

irshadjsr21 commented Apr 27, 2020

@beerose All the requested changes have been made.

@irshadjsr21 irshadjsr21 requested a review from beerose April 27, 2020 19:04
@netlify
Copy link

netlify bot commented Apr 27, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 4e10fa1

https://deploy-preview-4532--hasura-docs.netlify.app

@hasura-bot
Copy link
Contributor

hasura-bot commented Apr 27, 2020

Review app for commit 6f17667 deployed to Heroku: https://hge-ci-pull-4532.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4532-6f176671

beerose
beerose approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 🎉

Approving.

@hasura-bot
Copy link
Contributor

hasura-bot commented May 11, 2020

Review app for commit 653594f deployed to Heroku: https://hge-ci-pull-4532.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4532-653594f1

@beerose beerose assigned rikinsk and unassigned beerose May 11, 2020
@rikinsk rikinsk merged commit d039c12 into hasura:master May 14, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented May 14, 2020

Beep boop! 🤖

GIF

Awesome work @irshadjsr21! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

hasura-bot commented May 14, 2020

Review app https://hge-ci-pull-4532.herokuapp.com is deleted

@beerose beerose mentioned this pull request May 14, 2020
Closed
46 tasks
stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@irshadjsr21 @stevefan1999-personal
console: migrate Common/Modal to TypeScript (hasura#4532)
b968693
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rikinsk rikinsk

Labels

c/console Related to console community-contrib 🙏🏽 no-changelog-required typescript-migration 🙌

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@irshadjsr21 @hasura-bot @CLAassistant @beerose @rikinsk