-
Notifications
You must be signed in to change notification settings - Fork 2.8k
unlock event if event trigger info is not found in cache #4213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review app for commit c41bb2b deployed to Heroku: https://hge-ci-pull-4213.herokuapp.com |
server/src-lib/Hasura/Events/Lib.hs
Outdated
| case meti of | ||
| Nothing -> do | ||
| logQErr $ err500 Unexpected "table or event-trigger not found in schema cache" | ||
| liftIO . runExceptT $ Q.runTx pool (Q.RepeatableRead, Just Q.ReadWrite) $ unlockEvent e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To prevent starvation of other events, we can also set this to retry after 60 seconds and exponential back-off etc (when we have it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tirumaraiselvan Can you document known scenarios where this could happen?
c41bb2b to
aef9f0d
Compare
|
Deploy preview for hasura-docs ready! Built with commit aef9f0d |
|
Review app for commit aef9f0d deployed to Heroku: https://hge-ci-pull-4213.herokuapp.com |
|
Review app for commit ed6c1f2 deployed to Heroku: https://hge-ci-pull-4213.herokuapp.com |
ed6c1f2 to
be516eb
Compare
be516eb to
c2affab
Compare
c2affab to
b343a56
Compare
|
Review app for commit b343a56 deployed to Heroku: https://hge-ci-pull-4213.herokuapp.com |
|
Review app https://hge-ci-pull-4213.herokuapp.com is deleted |
|
Review app for commit 10fd419 deployed to Heroku: https://hge-ci-pull-4213.herokuapp.com |
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
Description
In the unexpected scenario in which table or event trigger info is not found in schema cache for a event, we were logging an error. We also need to unlock the event so that it can be reprocessed.
Affected components