这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@tirumaraiselvan
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan commented Mar 27, 2020

Description

In the unexpected scenario in which table or event trigger info is not found in schema cache for a event, we were logging an error. We also need to unlock the event so that it can be reprocessed.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

@tirumaraiselvan tirumaraiselvan added this to the v1.2 milestone Mar 27, 2020
@hasura-bot
Copy link
Contributor

Review app for commit c41bb2b deployed to Heroku: https://hge-ci-pull-4213.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4213-c41bb2b6

case meti of
Nothing -> do
logQErr $ err500 Unexpected "table or event-trigger not found in schema cache"
liftIO . runExceptT $ Q.runTx pool (Q.RepeatableRead, Just Q.ReadWrite) $ unlockEvent e
Copy link
Contributor Author

@tirumaraiselvan tirumaraiselvan Mar 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To prevent starvation of other events, we can also set this to retry after 60 seconds and exponential back-off etc (when we have it).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tirumaraiselvan Can you document known scenarios where this could happen?

@tirumaraiselvan tirumaraiselvan removed this from the v1.2 milestone Apr 1, 2020
@tirumaraiselvan tirumaraiselvan requested a review from a team as a code owner April 7, 2020 06:56
@tirumaraiselvan tirumaraiselvan requested a review from 0x777 April 7, 2020 06:57
@netlify
Copy link

netlify bot commented Apr 7, 2020

Deploy preview for hasura-docs ready!

Built with commit aef9f0d

https://deploy-preview-4213--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

Review app for commit aef9f0d deployed to Heroku: https://hge-ci-pull-4213.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4213-aef9f0d7

@hasura-bot
Copy link
Contributor

Review app for commit ed6c1f2 deployed to Heroku: https://hge-ci-pull-4213.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4213-ed6c1f2c

@tirumaraiselvan tirumaraiselvan requested a review from a team as a code owner April 9, 2020 05:45
@hasura-bot
Copy link
Contributor

Review app for commit b343a56 deployed to Heroku: https://hge-ci-pull-4213.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4213-b343a569

@0x777 0x777 merged commit ebb3bb3 into hasura:master Apr 9, 2020
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-4213.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

Review app for commit 10fd419 deployed to Heroku: https://hge-ci-pull-4213.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4213-10fd4196

abooij pushed a commit to lexi-lambda/graphql-engine that referenced this pull request Jul 16, 2020
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants