-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Event triggers refactor #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
tirumaraiselvan
wants to merge
7
commits into
hasura:master
from
tirumaraiselvan:event_triggers_refactor
Closed
Event triggers refactor #377
tirumaraiselvan
wants to merge
7
commits into
hasura:master
from
tirumaraiselvan:event_triggers_refactor
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…triggers_refactor # Conflicts: # server/src-lib/Hasura/RQL/DDL/Subscribe.hs
Contributor
|
Review app available at: https://hge-ci-pull-377.herokuapp.com |
Contributor
Author
|
Should success and failure set retry_after to null? |
Contributor
|
Review app available at: https://hge-ci-pull-377.herokuapp.com |
1 similar comment
Contributor
|
Review app available at: https://hge-ci-pull-377.herokuapp.com |
Contributor
Author
|
Need catalog update. |
Member
|
@tirumaraiselvan Add the catalog update code? |
Contributor
Author
|
Merged with #419 |
Contributor
|
Review app https://hge-ci-pull-377.herokuapp.com is deleted |
hasura-bot
pushed a commit
that referenced
this pull request
Mar 21, 2024
## Description This PR adds a check which ensures that empty selection sets (i.e., selecting a field of object type (or list of object type)) in queries raise an error. ## Changelog - Add a changelog entry (in the "Changelog entry" section below) if the changes in this PR have any user-facing impact. See [changelog guide](https://github.com/hasura/graphql-engine-mono/wiki/Changelog-Guide). - If no changelog is required ignore/remove this section and add a `no-changelog-required` label to the PR. ### Product _(Select all products this will be available in)_ - [x] community-edition - [x] cloud <!-- product : end : DO NOT REMOVE --> ### Type <!-- See changelog structure: https://github.com/hasura/graphql-engine-mono/wiki/Changelog-Guide#structure-of-our-changelog --> _(Select only one. In case of multiple, choose the most appropriate)_ - [ ] highlight - [ ] enhancement - [x] bugfix - [ ] behaviour-change - [ ] performance-enhancement - [ ] security-fix <!-- type : end : DO NOT REMOVE --> ### Changelog entry <!-- - Add a user understandable changelog entry - Include all details needed to understand the change. Try including links to docs or issues if relevant - For Highlights start with a H4 heading (#### <entry title>) - Get the changelog entry reviewed by your team --> Ensure to reject queries with empty selection sets <!-- changelog-entry : end : DO NOT REMOVE --> <!-- changelog : end : DO NOT REMOVE --> V3_GIT_ORIGIN_REV_ID: 79049c39b58288f39ec29ecf713cc3622842d47e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.