这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@tirumaraiselvan
Copy link
Contributor

No description provided.

@tirumaraiselvan tirumaraiselvan added the s/do-not-merge Do not merge this pull request to master label Sep 7, 2018
@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-377.herokuapp.com

@tirumaraiselvan
Copy link
Contributor Author

Should success and failure set retry_after to null?

@tirumaraiselvan tirumaraiselvan added s/ok-to-merge Status: This pull request can be merged to master and removed s/do-not-merge Do not merge this pull request to master labels Sep 10, 2018
@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-377.herokuapp.com

1 similar comment
@hasura-bot
Copy link
Contributor

Review app available at: https://hge-ci-pull-377.herokuapp.com

@tirumaraiselvan tirumaraiselvan removed the s/ok-to-merge Status: This pull request can be merged to master label Sep 10, 2018
@tirumaraiselvan
Copy link
Contributor Author

Need catalog update.

@shahidhk shahidhk added c/server Related to server s/do-not-merge Do not merge this pull request to master labels Sep 10, 2018
@0x777
Copy link
Member

0x777 commented Sep 11, 2018

@tirumaraiselvan Add the catalog update code?

@tirumaraiselvan
Copy link
Contributor Author

Merged with #419

@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-377.herokuapp.com is deleted

@tirumaraiselvan tirumaraiselvan deleted the event_triggers_refactor branch September 26, 2018 11:44
hasura-bot pushed a commit that referenced this pull request Mar 21, 2024
## Description

This PR adds a check which ensures that empty selection sets (i.e.,
selecting a field of object type (or list of object type)) in queries
raise an error.

## Changelog

- Add a changelog entry (in the "Changelog entry" section below) if the
changes in this PR have any user-facing impact. See [changelog
guide](https://github.com/hasura/graphql-engine-mono/wiki/Changelog-Guide).
- If no changelog is required ignore/remove this section and add a
`no-changelog-required` label to the PR.

### Product
_(Select all products this will be available in)_
- [x] community-edition
- [x] cloud
<!-- product : end : DO NOT REMOVE -->

### Type
<!-- See changelog structure:
https://github.com/hasura/graphql-engine-mono/wiki/Changelog-Guide#structure-of-our-changelog
-->
_(Select only one. In case of multiple, choose the most appropriate)_
- [ ] highlight
- [ ] enhancement
- [x] bugfix
- [ ] behaviour-change
- [ ] performance-enhancement
- [ ] security-fix
<!-- type : end : DO NOT REMOVE -->

### Changelog entry
<!--
  - Add a user understandable changelog entry
- Include all details needed to understand the change. Try including
links to docs or issues if relevant
  - For Highlights start with a H4 heading (#### <entry title>)
  - Get the changelog entry reviewed by your team
-->

Ensure to reject queries with empty selection sets

<!-- changelog-entry : end : DO NOT REMOVE -->

<!-- changelog : end : DO NOT REMOVE -->

V3_GIT_ORIGIN_REV_ID: 79049c39b58288f39ec29ecf713cc3622842d47e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/server Related to server s/do-not-merge Do not merge this pull request to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants