-
Notifications
You must be signed in to change notification settings - Fork 2.8k
change success code from 200 to 2xx (close #2335) #2342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Beep boop! 🤖 Hey @strongSoda, thanks for your PR! One of my human friends will review this PR and get back to you as soon as possible. 🕐 Stay awesome! 😎 |
|
Deploy preview for hasura-docs ready! Built with commit 9a3102f |
|
Review app for commit 68d9d0c deployed to Heroku: https://hge-ci-pull-2342.herokuapp.com |
|
@strongSoda can you move the testing of status code to a util function and use that everywhere instead of repeating the regex match. Also use a stronger regex. like |
|
done |
|
@rikinsk shall I change the util function name from |
|
Review app for commit b03a1d5 deployed to Heroku: https://hge-ci-pull-2342.herokuapp.com |
|
@strongSoda |
|
done @rikinsk |
|
Review app for commit 3ad4ac6 deployed to Heroku: https://hge-ci-pull-2342.herokuapp.com |
|
Review app https://hge-ci-pull-2342.herokuapp.com is deleted |
|
Beep boop! 🤖 Whoa! 🎉 🎉 💃 Awesome work @strongSoda! 💪 🏆 All of us at Hasura ❤️ what you did. Thanks again 🤗 |
|
Review app for commit 9a3102f deployed to Heroku: https://hge-ci-pull-2342.herokuapp.com |
fix issue #2335
Affected components
Related Issues
#2335