这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@strongSoda
Copy link
Contributor

fix issue #2335

Affected components

  • Console

Related Issues

#2335

@strongSoda strongSoda added the c/console Related to console label Jun 6, 2019
@strongSoda strongSoda requested a review from rikinsk-zz as a code owner June 6, 2019 11:47
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @strongSoda, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible. 🕐

Stay awesome! 😎

@netlify
Copy link

netlify bot commented Jun 6, 2019

Deploy preview for hasura-docs ready!

Built with commit 9a3102f

https://deploy-preview-2342--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

Review app for commit 68d9d0c deployed to Heroku: https://hge-ci-pull-2342.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2342-68d9d0c2

@rikinsk-zz
Copy link

@strongSoda can you move the testing of status code to a util function and use that everywhere instead of repeating the regex match. Also use a stronger regex. like 2[0-9][0-9]

@strongSoda
Copy link
Contributor Author

done

@strongSoda
Copy link
Contributor Author

@rikinsk shall I change the util function name from verifyStatus to more specific verifySuccessStatus ?

@hasura-bot
Copy link
Contributor

Review app for commit b03a1d5 deployed to Heroku: https://hge-ci-pull-2342.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2342-b03a1d5f

@rikinsk-zz
Copy link

@strongSoda verifySuccessStatus seems like a better name

@strongSoda
Copy link
Contributor Author

done @rikinsk

@hasura-bot
Copy link
Contributor

Review app for commit 3ad4ac6 deployed to Heroku: https://hge-ci-pull-2342.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2342-3ad4ac65

@rikinsk-zz rikinsk-zz merged commit de09c29 into hasura:master Jun 7, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-2342.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Whoa! 🎉 🎉 💃

GIF

Awesome work @strongSoda! 💪 🏆 All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

Review app for commit 9a3102f deployed to Heroku: https://hge-ci-pull-2342.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2342-9a3102fb

@strongSoda strongSoda deleted the eventStatus branch June 19, 2019 06:23
polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/console Related to console

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants