这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@rikinsk-zz
Copy link

@rikinsk-zz rikinsk-zz commented Apr 2, 2019

Description

  • Make permissions sections as collapsibles with tooltips
  • Remove 'use same permission as select' type options from row permissions section
  • Added clone section to apply same permission to any table-role-action
  • Disable other subsections till row permissions are set

Affected components

  • Console

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@rikinsk-zz rikinsk-zz added the c/console Related to console label Apr 2, 2019
@netlify
Copy link

netlify bot commented Apr 2, 2019

Deploy preview for hasura-docs ready!

Built with commit 28f488e

https://deploy-preview-1924--hasura-docs.netlify.com

@rikinsk-zz rikinsk-zz marked this pull request as ready for review April 5, 2019 10:34
@rikinsk-zz rikinsk-zz added the s/do-not-merge Do not merge this pull request to master label Apr 5, 2019
@hasura-bot
Copy link
Contributor

Review app for commit 6c6477e deployed to Heroku: https://hge-ci-pull-1924.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1924-6c6477e

@rikinsk-zz rikinsk-zz force-pushed the console-permissions branch from 24ca3a6 to 0c81f7d Compare April 5, 2019 11:46
@hasura-bot
Copy link
Contributor

Review app for commit 0c81f7d deployed to Heroku: https://hge-ci-pull-1924.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1924-0c81f7d

@coco98
Copy link
Contributor

coco98 commented Apr 5, 2019

I really like it! ❤️

I think the only thing I miss from the old UI is that we don't have "copy permissions from insert" type setting when I do select.

Second, do you think we should have the row-select section expanded by default when permissions are empty? And maybe we should select all the columns by default? So that if I just end up setting a row-level check but not a column level check (it was not expanded so I didn't care), my query still works...

@hasura-bot
Copy link
Contributor

Review app for commit 3471f17 deployed to Heroku: https://hge-ci-pull-1924.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1924-3471f17

@hasura-bot
Copy link
Contributor

Review app for commit cbaccdf deployed to Heroku: https://hge-ci-pull-1924.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1924-cbaccdf

@hasura-bot
Copy link
Contributor

Review app for commit dabd161 deployed to Heroku: https://hge-ci-pull-1924.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1924-dabd161

@rikinsk-zz rikinsk-zz added s/ok-to-merge Status: This pull request can be merged to master and removed s/do-not-merge Do not merge this pull request to master labels Apr 9, 2019
@shahidhk shahidhk changed the title update console permissions UI update console permissions ui Apr 9, 2019
@rikinsk-zz rikinsk-zz merged commit 1a4f172 into hasura:master Apr 9, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1924.herokuapp.com is deleted

@rikinsk-zz rikinsk-zz deleted the console-permissions branch April 9, 2019 11:55
@hasura-bot
Copy link
Contributor

Review app for commit 28f488e deployed to Heroku: https://hge-ci-pull-1924.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1924-28f488e

wawhal pushed a commit to wawhal/graphql-engine that referenced this pull request Apr 11, 2019
* Make permissions sections as collapsibles with tooltips
* Remove 'use same permission as select' type options from row permissions section
* Added clone section to apply same permission to any table-role-action
* Disable other subsections till row permissions are set
tirumaraiselvan pushed a commit to tirumaraiselvan/graphql-engine that referenced this pull request Apr 11, 2019
* added feedback on migration commands (close hasura#1410) (hasura#1931)

* firebase2graphql (v0.0.2): support array types in firebase json (close hasura#1829) (hasura#1900)

* improve console error page (close hasura#272) (hasura#1890)

* add nextjs 8 jwt sample app (hasura#1943)

* persist queries in GraphiQL (closes hasura#1894) (hasura#1903)

* add realtime chat sample app with vue (hasura#1885)

* fix update_event_trigger query not persisting the changes (hasura#1950)

fix hasura#1949

* mention required key length for HMAC encryption to user (hasura#1956)

Following on from a discussion in discord, a small tweak to make the required key length for a HMAC key more obvious

* fix input argument types for custom SQL functions (close hasura#1952) (hasura#1953)

* run graphql tests on both http and websocket; add parallelism (close hasura#1868) (hasura#1921)

Examples 
1)  `
pytest --hge-urls "http://127.0.0.1:8080" --pg-urls "postgresql://admin@127.0.0.1:5432/hge_tests" -vv
`
2)  `pytest --hge-urls "http://127.0.0.1:8080"   "http://127.0.0.1:8081" --pg-urls "postgresql://admin@127.0.0.1:5432/hge_tests"  "postgresql://admin@127.0.0.1:5432/hge_tests2" -vv
`
### Solution and Design
<!-- How is this issue solved/fixed? What is the design? -->
<!-- It's better if we elaborate -->
#### Reducing execution time of tests
- The Schema setup and teardown, which were earlier done per test method, usually takes around 1 sec. 
- For mutations, the model has now been changed to only do schema setup and teardown once per test class.
-  A data setup and teardown will be done once per test instead (usually takes ~10ms).
- For the test class to get this behaviour, one can can extend the class `DefaultTestMutations`. 
    - The function  `dir()` should be define which returns the location of the configuration folder.
    - Inside the configuration folder, there should be 
        - Files `<conf_dir>/schema_setup.yaml` and `<conf_dir>/schema_teardown.yaml`, which has the metadata query executed during schema setup and teardown respectively
        - Files named `<conf_dir>/values_setup.yaml` and `<conf_dir>/values_teardown.yaml`. These files are executed to setup and remove data from the tables respectively. 

#### Running Graphql queries on both http and websockets
- Each GraphQL query/mutation is run on the both HTTP and websocket protocols
- Pytests test parameterisation is used to achieve this
- The errors over websockets are slightly different from that on HTTP
   - The code takes care of converting the errors in HTTP to errors in websockets

#### Parallel executation of tests.
- The plugin pytest-xdist helps in running tests on parallel workers.
- We are using this plugin to group tests by file and run on different workers.
- Parallel test worker processes operate on separate postgres databases(and separate graphql-engines connected to these databases). Thus tests on one worker will not affect the tests on the other worker.
- With two workers, this decreases execution times by half, as the tests on event triggers usually takes a long time, but does not consume much CPU.

* update manifests to v1.0.0-alpha42

* update regex to delete event triggers in edit-pg-dump (close hasura#1959) (hasura#1960)

* support composite foreign keys and primary keys through console (close hasura#1707) (hasura#1854)

* edit-pg-dump: fix a missing semi-colon

* fix styles in browse rows, relationship and permission tables (hasura#1969)

* update console permissions ui (hasura#1924)

* Make permissions sections as collapsibles with tooltips
* Remove 'use same permission as select' type options from row permissions section
* Added clone section to apply same permission to any table-role-action
* Disable other subsections till row permissions are set

* re-add same as other action options in permissions (hasura#1970)

* fix excessive memory consumption with bulk queries (hasura#1972)

Use 'Strict' State monad instead of 'Lazy' to avoid unevaluated memory thunks

* add placeholder for bool type fields while inserting rows (hasura#1962)

* Use UTF-8 encoding for stack hpc report generation (hasura#1974)

* fix save function in console's retry config editor (fix hasura#1975) (hasura#1976)

* Wip

* add scroll to literal blocks in docs (close hasura#1954) (hasura#1978)

* remote relationship ui v1

* wip

* ui for creating remote relationships

* wip

* ui fixes

* ui fixes

* functional ui

* namespace ui wip

* add functionality for dropping relationship

* show exact error in notification

* fix state inconsistencies

* update reldef for namespaced fields

* lint
polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
* Make permissions sections as collapsibles with tooltips
* Remove 'use same permission as select' type options from row permissions section
* Added clone section to apply same permission to any table-role-action
* Disable other subsections till row permissions are set
hasura-bot pushed a commit that referenced this pull request May 29, 2025
<!-- The PR description should answer 2 important questions: -->

### What

Update changelog for `v2025.05.29` release.

V3_GIT_ORIGIN_REV_ID: 9bdd097643c381ab269838e447bab5d7b00562ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants