这是indexloc提供的服务,不要输入任何密码
Skip to content

Console: retry configuration editing is broken #1975

@MathiasGr

Description

@MathiasGr

On the latest release, trying to update the events' retry settings leads to this error:

Updating trigger failed
expected Int, encountered String

After looking at the Network logs, I found out the num_retries, interval_sec and timeout_sec variables are being sent as Strings. Here's an example when updating the num_retries:

{
    "retry_conf":{"num_retries":"10","interval_sec":10,"timeout_sec":60}
}

It turns out the proper validation that uses parseInt to turn the input strings into ints was coded but never used anywhere in the code.

I'm submitting a PR right away to properly call the validateAndSave method

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions