这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@rikinsk-zz
Copy link

@rikinsk-zz rikinsk-zz commented Mar 13, 2019

Description

Affected components

  • Console
  • Docs
  • Server
  • CLI

Related Issues

#1485

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@rikinsk-zz rikinsk-zz requested a review from dsandip March 13, 2019 10:44
@shahidhk
Copy link
Member

/heroku deploy

@hasura-bot
Copy link
Contributor

Review app for commit 2ef5bdb deployed to Heroku: https://hge-ci-pull-1760.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1760-2ef5bdb

@shahidhk
Copy link
Member

@rikinsk This requires change in server and cli templates for console.

@shahidhk shahidhk added c/console Related to console c/docs Related to docs labels Mar 15, 2019
@rikinsk-zz rikinsk-zz added the s/do-not-merge Do not merge this pull request to master label Mar 16, 2019
@netlify
Copy link

netlify bot commented Mar 19, 2019

Deploy preview for hasura-docs ready!

Built with commit 178063a

https://deploy-preview-1760--hasura-docs.netlify.com

Copy link
Member

@shahidhk shahidhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on server and CLI.

@hasura-bot
Copy link
Contributor

Review app for commit 8242d8b deployed to Heroku: https://hge-ci-pull-1760.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1760-8242d8b

@shahidhk shahidhk removed the s/do-not-merge Do not merge this pull request to master label Mar 19, 2019
@hasura-bot
Copy link
Contributor

Review app for commit 178063a deployed to Heroku: https://hge-ci-pull-1760.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1760-178063a

@shahidhk shahidhk merged commit 1ba3821 into hasura:master Mar 25, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1760.herokuapp.com is deleted

@rikinsk-zz rikinsk-zz deleted the update-favicons branch May 21, 2019 08:29
hasura-bot pushed a commit that referenced this pull request Mar 20, 2025
<!-- The PR description should answer 2 important questions: -->

### What

Introduce tests for json:api execution. Tests can be defined in any
existing graphql execution folder with the following files:
- `request_jsonapi.json` to define json:api requests. Find a sample
below.
```json
[
  {
    "GET": "/default/Authors"
  },
  {
    "GET": "/default/Authors?fields[author]=author_id,first_name"
  }
]
```
It has support to specify HTTP method, we may introduce `POST` in future
to support mutations, and multiple requests per file.
- `expected_jsonapi.json` contains a 2-d array of responses from
json:api where inner list holds response per request defined in requests
json and outer list corresponds to response list per session variable
set defined in `session_variables.json`.

### How

- Update `common.rs` module in engine tests with json:api test
implementation. Run json:api tests in the same execution code path as
graphql tests utilizing the same metadata.
- Add a sample test.

V3_GIT_ORIGIN_REV_ID: ae74dd7c7c72d764259647a9db93393dacd05306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/console Related to console c/docs Related to docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants