-
Notifications
You must be signed in to change notification settings - Fork 2.8k
update console and docs favicons (close #1485) #1760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/heroku deploy |
|
Review app for commit 2ef5bdb deployed to Heroku: https://hge-ci-pull-1760.herokuapp.com |
|
@rikinsk This requires change in server and cli templates for console. |
|
Deploy preview for hasura-docs ready! Built with commit 178063a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested on server and CLI.
|
Review app for commit 8242d8b deployed to Heroku: https://hge-ci-pull-1760.herokuapp.com |
|
Review app for commit 178063a deployed to Heroku: https://hge-ci-pull-1760.herokuapp.com |
|
Review app https://hge-ci-pull-1760.herokuapp.com is deleted |
<!-- The PR description should answer 2 important questions: -->
### What
Introduce tests for json:api execution. Tests can be defined in any
existing graphql execution folder with the following files:
- `request_jsonapi.json` to define json:api requests. Find a sample
below.
```json
[
{
"GET": "/default/Authors"
},
{
"GET": "/default/Authors?fields[author]=author_id,first_name"
}
]
```
It has support to specify HTTP method, we may introduce `POST` in future
to support mutations, and multiple requests per file.
- `expected_jsonapi.json` contains a 2-d array of responses from
json:api where inner list holds response per request defined in requests
json and outer list corresponds to response list per session variable
set defined in `session_variables.json`.
### How
- Update `common.rs` module in engine tests with json:api test
implementation. Run json:api tests in the same execution code path as
graphql tests utilizing the same metadata.
- Add a sample test.
V3_GIT_ORIGIN_REV_ID: ae74dd7c7c72d764259647a9db93393dacd05306
Description
Affected components
Related Issues
#1485
Solution and Design
Steps to test and verify
Limitations, known bugs & workarounds