-
Notifications
You must be signed in to change notification settings - Fork 2.8k
make events and remote-schema tabs independent of update checker #1604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rikinsk-zz
merged 5 commits into
hasura:master
from
wawhal:update-checker-blocks-further-actiosn
Feb 17, 2019
Merged
make events and remote-schema tabs independent of update checker #1604
rikinsk-zz
merged 5 commits into
hasura:master
from
wawhal:update-checker-blocks-further-actiosn
Feb 17, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and event triggers tab from loading
praveenweb
reviewed
Feb 15, 2019
praveenweb
reviewed
Feb 15, 2019
praveenweb
reviewed
Feb 15, 2019
Contributor
|
Review app for commit ad7a173 deployed to Heroku: https://hge-ci-pull-1604.herokuapp.com |
praveenweb
approved these changes
Feb 15, 2019
Contributor
|
Review app for commit 5bf307a deployed to Heroku: https://hge-ci-pull-1604.herokuapp.com |
Contributor
|
Review app https://hge-ci-pull-1604.herokuapp.com is deleted |
hasura-bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
…errors and JSON schema issues (#1604) ### What This PR fixes an issue where invalid JSON pointers specified inside AuthConfig's `jwt.claimsConfig.locations` would cause all extra claims added there to be silently dropped. It also fixes the AuthConfig JSON schema generation so that JWTClaimsMap actually specifies the proper type of the additional properties allowed on that object (which are the custom claims). The lack of this explicit definition is likely why the CLI is dropping these claims when it creates the metadata to send to MBS. ### How The silent dropping of the extra claims when an invalid JSON pointer was encountered is because of the weird interaction between serde's flatten and Option. In this case, a deserialization error causes flatten to throw away the error and just return a None for the option. This has been fixed by removing the Option which was unnecessary anyway. This change introduces "new" errors, but existing builds won't have any custom claims anyway, since the CLI has been dropping them, so we've dodged a bullet and don't need a flag and a workaround to deal with that. Schema diff tests are still passing, which appears to validate this hypothesis. The JWTClaimsMap JSON schema issue has been worked around with an extra macro attribute. V3_GIT_ORIGIN_REV_ID: 2c6b53be6d567ec5173737097625727040afe9be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue reported by @Maxpain177 on Discord.
When the update checker request failed, it blocked semver checks for
remote-schemasandevent-triggers.This PR makes the update checker async.
Also fixes a small bug with local development where incorrect
window.__envwas templated from local.env.Description
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
Solution and Design
Type
Checklist: