这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@wawhal
Copy link
Contributor

@wawhal wawhal commented Feb 14, 2019

Issue reported by @Maxpain177 on Discord.
When the update checker request failed, it blocked semver checks for remote-schemas and event-triggers.
This PR makes the update checker async.
Also fixes a small bug with local development where incorrect window.__env was templated from local .env.

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@wawhal wawhal requested a review from praveenweb as a code owner February 14, 2019 12:05
@wawhal wawhal changed the title make events and remote-schema page independent of update checker make events and remote-schema tabs independent of update checker Feb 14, 2019
@hasura-bot
Copy link
Contributor

Review app for commit ad7a173 deployed to Heroku: https://hge-ci-pull-1604.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1604-ad7a173

@praveenweb praveenweb added s/ok-to-merge Status: This pull request can be merged to master c/console Related to console labels Feb 17, 2019
@hasura-bot
Copy link
Contributor

Review app for commit 5bf307a deployed to Heroku: https://hge-ci-pull-1604.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1604-5bf307a

@rikinsk-zz rikinsk-zz merged commit 386ab81 into hasura:master Feb 17, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1604.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Feb 5, 2025
…errors and JSON schema issues (#1604)

### What
This PR fixes an issue where invalid JSON pointers specified inside
AuthConfig's `jwt.claimsConfig.locations` would cause all extra claims
added there to be silently dropped.

It also fixes the AuthConfig JSON schema generation so that JWTClaimsMap
actually specifies the proper type of the additional properties allowed
on that object (which are the custom claims). The lack of this explicit
definition is likely why the CLI is dropping these claims when it
creates the metadata to send to MBS.

### How
The silent dropping of the extra claims when an invalid JSON pointer was
encountered is because of the weird interaction between serde's flatten
and Option. In this case, a deserialization error causes flatten to
throw away the error and just return a None for the option. This has
been fixed by removing the Option which was unnecessary anyway.

This change introduces "new" errors, but existing builds won't have any
custom claims anyway, since the CLI has been dropping them, so we've
dodged a bullet and don't need a flag and a workaround to deal with
that. Schema diff tests are still passing, which appears to validate
this hypothesis.

The JWTClaimsMap JSON schema issue has been worked around with an extra
macro attribute.

V3_GIT_ORIGIN_REV_ID: 2c6b53be6d567ec5173737097625727040afe9be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants