这是indexloc提供的服务，不要输入任何密码
Skip to content

refactor console code; update react to 16.8.2 (close #1467) #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 28, 2019
Merged

refactor console code; update react to 16.8.2 (close #1467) #1608

merged 7 commits into from
Feb 28, 2019

Conversation

@wawhal
Copy link
Contributor

@wawhal wawhal commented Feb 15, 2019

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@wawhal wawhal requested a review from praveenweb as a code owner February 15, 2019 10:06
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 15, 2019

Review app for commit e64681f deployed to Heroku: https://hge-ci-pull-1608.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1608-e64681f

@wawhal wawhal added k/enhancement New feature or improve an existing feature c/console Related to console s/do-not-merge Do not merge this pull request to master labels Feb 18, 2019
@wawhal
Copy link
Contributor Author

wawhal commented Feb 18, 2019

This PR involves a package-lock change. Should be merged after merging changes from #1618

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 25, 2019

Review app for commit 103b628 deployed to Heroku: https://hge-ci-pull-1608.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1608-103b628

@wawhal wawhal mentioned this pull request Feb 26, 2019
Closed
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 27, 2019

Review app for commit afb0918 deployed to Heroku: https://hge-ci-pull-1608.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1608-afb0918

karthikvt26
karthikvt26 approved these changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@karthikvt26 karthikvt26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahidhk shahidhk changed the title refactor console code; update react to 16.8.2 refactor console code; update react to 16.8.2 (close #1467) Feb 28, 2019
@praveenweb praveenweb added s/ok-to-merge Status: This pull request can be merged to master and removed s/do-not-merge Do not merge this pull request to master labels Feb 28, 2019
@shahidhk shahidhk merged commit a002d3a into hasura:master Feb 28, 2019
@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 28, 2019

Review app https://hge-ci-pull-1608.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Feb 6, 2025
@daniel-chambers @hasura-bot
Clean up duplicate DataConnectorLinks in engine tests and delete dead…
1a5ade4 
… tests (#1608)

### What
This PR removes a bunch of duplicate DataConnectorLinks in the engine
tests and gets tests to try to reuse the same DataConnectorLink from a
shared file where possible. Some tests needed minor adjustments to data
connector names or types to facilitate this.

It also deletes a few test files that are broken and have been unused
for years (the deleted tests in `multiple_root_fields`).

V3_GIT_ORIGIN_REV_ID: b90e3690d167bb04cccc9aa592d69b72b904a0fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveenweb praveenweb praveenweb approved these changes

@karthikvt26 karthikvt26 karthikvt26 approved these changes

Assignees

No one assigned

Labels

c/console Related to console k/enhancement New feature or improve an existing feature s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

update console to React 16.8

5 participants

@wawhal @hasura-bot @praveenweb @karthikvt26 @shahidhk