-
Notifications
You must be signed in to change notification settings - Fork 2.8k
upgrade to babel 7 and fix console hot reloading #1618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to babel 7 and fix console hot reloading #1618
Conversation
|
Review app for commit d393f6d deployed to Heroku: https://hge-ci-pull-1618.herokuapp.com |
|
Heavy props! Thanks for this @praveenweb :) |
wawhal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine. There's however this warning going on src/ApiExplorer/ApiRequest.js
Please remove that and let us merge this ASAP.
|
Review app for commit ec19e17 deployed to Heroku: https://hge-ci-pull-1618.herokuapp.com |
|
@karthikvt26 Please review. |
|
Review app for commit d871747 deployed to Heroku: https://hge-ci-pull-1618.herokuapp.com |
|
Review app https://hge-ci-pull-1618.herokuapp.com is deleted |
<!-- The PR description should answer 2 important questions: -->
This PR adds v3 of the AuthConfig, which will allow users to configure
the headers in the auth webhook.
We are also allowing users to configure the auth hook URL using env
vars.
- [x] Figure out what we should do for POST auth hooks
- [ ] Update docs
### What
This PR adds AuthConfig v3.
GET:
```json
{
"version": "v3",
"definition": {
"mode": {
"webhook": {
"method": "GET",
"url": {
"value": "http://auth_hook:3050/validate-request"
},
"customHeadersConfig": {
"headers": {
"forward": ["Authorization"],
"additional": {
"user-agent": "hasura-ddn"
}
}
}
}
}
}
}
```
POST:
```json
{
"version": "v3",
"definition": {
"mode": {
"webhook": {
"method": "POST",
"url": {
"value": "http://auth_hook:3050/validate-request"
},
"customHeadersConfig": {
"headers": {
"additional": {
"user-agent": "hasura-ddn"
}
},
"body": {
"headers": {
"forward": "*"
}
}
}
}
}
}
}
```
This config allows us to configure the headers sent to the auth
webhooks.
**Note**: Other auth mode configuration remains the same.
### How
<!-- How is it trying to accomplish it (what are the implementation
steps)? -->
---------
Co-authored-by: Daniel Chambers <daniel@hasura.io>
V3_GIT_ORIGIN_REV_ID: 4c86aeb3b0a335fe33bd24bb536fb3d98f501cdb
Description
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
Solution and Design
Type
Checklist: