这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@praveenweb
Copy link
Member

@praveenweb praveenweb commented Feb 18, 2019

Description

  • Upgrade Babel to v7 (This also helped in removing unused code and fix bad exports)
  • Use react-hot-loader and fix console hot reloading

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@praveenweb praveenweb added the c/console Related to console label Feb 18, 2019
@hasura-bot
Copy link
Contributor

Review app for commit d393f6d deployed to Heroku: https://hge-ci-pull-1618.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1618-d393f6d

@wawhal
Copy link
Contributor

wawhal commented Feb 18, 2019

Heavy props! Thanks for this @praveenweb :)

Copy link
Contributor

@wawhal wawhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine. There's however this warning going on src/ApiExplorer/ApiRequest.js
Please remove that and let us merge this ASAP.

@hasura-bot
Copy link
Contributor

Review app for commit ec19e17 deployed to Heroku: https://hge-ci-pull-1618.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1618-ec19e17

@shahidhk
Copy link
Member

@karthikvt26 Please review.

@hasura-bot
Copy link
Contributor

Review app for commit d871747 deployed to Heroku: https://hge-ci-pull-1618.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1618-d871747

@praveenweb praveenweb added the s/ok-to-merge Status: This pull request can be merged to master label Feb 19, 2019
@rikinsk-zz rikinsk-zz merged commit 6ef0b4d into hasura:master Feb 19, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1618.herokuapp.com is deleted

@praveenweb praveenweb deleted the console-deps-update-feb19 branch May 21, 2019 06:59
hasura-bot pushed a commit that referenced this pull request Feb 17, 2025
<!-- The PR description should answer 2 important questions: -->

This PR adds v3 of the AuthConfig, which will allow users to configure
the headers in the auth webhook.

We are also allowing users to configure the auth hook URL using env
vars.

- [x] Figure out what we should do for POST auth hooks
- [ ] Update docs

### What

This PR adds AuthConfig v3.

GET:
```json
{
  "version": "v3",
  "definition": {
    "mode": {
      "webhook": {
        "method": "GET",
        "url": {
          "value": "http://auth_hook:3050/validate-request"
        },
        "customHeadersConfig": {
          "headers": {
            "forward": ["Authorization"],
            "additional": {
              "user-agent": "hasura-ddn"
            }
          }
        }
      }
    }
  }
}
```

POST:
```json
{
  "version": "v3",
  "definition": {
    "mode": {
      "webhook": {
        "method": "POST",
        "url": {
          "value": "http://auth_hook:3050/validate-request"
        },
        "customHeadersConfig": {
          "headers": {
            "additional": {
              "user-agent": "hasura-ddn"
            }
          },
          "body": {
            "headers": {
              "forward": "*"
            }
          }
        }
      }
    }
  }
}
```

This config allows us to configure the headers sent to the auth
webhooks.

**Note**: Other auth mode configuration remains the same.

### How

<!-- How is it trying to accomplish it (what are the implementation
steps)? -->

---------

Co-authored-by: Daniel Chambers <daniel@hasura.io>
V3_GIT_ORIGIN_REV_ID: 4c86aeb3b0a335fe33bd24bb536fb3d98f501cdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants