-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix console link on schema change #1389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review app for commit 181fe4f deployed to Heroku: https://hge-ci-pull-1389.herokuapp.com |
rikinsk-zz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing schema is not actually changing schema unless i refresh the page. Metadata needs refreshing with new schema maybe.
|
Review app for commit f2b682a deployed to Heroku: https://hge-ci-pull-1389.herokuapp.com |
|
Review app for commit a6f5712 deployed to Heroku: https://hge-ci-pull-1389.herokuapp.com |
rikinsk-zz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality seems to work
|
Review app https://hge-ci-pull-1389.herokuapp.com is deleted |
<!-- The PR description should answer 2 important questions: --> ### What <!-- What is this PR trying to accomplish (and why, if it's not obvious)? --> <!-- Consider: do we need to add a changelog entry? --> <!-- Does this PR introduce new validation that might break old builds? --> <!-- Consider: do we need to put new checks behind a flag? --> This PR add support for sparse fieldset parameter for the object types of nested fields. Specify the fields to fetch using `fields[NestedObjectType]` query parameter. E.g: ```http GET /v1/rest/default/institutions?fields[institution]=name,location,staff&fields[location]=city,country&fields[staff_member]=first_name,specialities&page[limit]=5 ``` In the above example, `location` and `staff_member` are nested object types of `location` and `staff` fields respectively. ### How - Resolve the nested fields while building OpenDD query IR for a json:api request. - During planning, always resolve nested selection, if exists, instead of selecting all available fields from the nested type. (This is only applicable for model selection, the commands are still using older approach for nested fields. This will be fixed in the future iterations). - Resolve sub-selections of graphql fields in opendd pipeline. Related test snaps are corrected. - Include sparse fieldset parameters for nested types in the openapi schema <!-- How is it trying to accomplish it (what are the implementation steps)? --> V3_GIT_ORIGIN_REV_ID: 587eecb79b6b8fac45f2eb6ffb37bf5fdcc7e374
Description
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
Solution and Design
Type
Checklist: