这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@wawhal
Copy link
Contributor

@wawhal wawhal commented Jan 16, 2019

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@wawhal wawhal added k/bug Something isn't working c/console Related to console labels Jan 16, 2019
@wawhal wawhal requested a review from praveenweb January 16, 2019 09:42
@hasura-bot
Copy link
Contributor

Review app for commit 181fe4f deployed to Heroku: https://hge-ci-pull-1389.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1389-181fe4f

@rikinsk-zz rikinsk-zz self-requested a review January 16, 2019 12:14
Copy link

@rikinsk-zz rikinsk-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing schema is not actually changing schema unless i refresh the page. Metadata needs refreshing with new schema maybe.

@rikinsk-zz rikinsk-zz changed the title fix bug where tracked tables were being shown as untracked fix console link on schema change Jan 16, 2019
@hasura-bot
Copy link
Contributor

Review app for commit f2b682a deployed to Heroku: https://hge-ci-pull-1389.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1389-f2b682a

@hasura-bot
Copy link
Contributor

Review app for commit a6f5712 deployed to Heroku: https://hge-ci-pull-1389.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1389-a6f5712

Copy link

@rikinsk-zz rikinsk-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality seems to work

@shahidhk shahidhk merged commit 26a9972 into hasura:master Jan 17, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1389.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Nov 29, 2024
<!-- The PR description should answer 2 important questions: -->

### What

<!-- What is this PR trying to accomplish (and why, if it's not
obvious)? -->

<!-- Consider: do we need to add a changelog entry? -->

<!-- Does this PR introduce new validation that might break old builds?
-->

<!-- Consider: do we need to put new checks behind a flag? -->
This PR add support for sparse fieldset parameter for the object types
of nested fields. Specify the fields to fetch using
`fields[NestedObjectType]` query parameter.
E.g:
```http
GET /v1/rest/default/institutions?fields[institution]=name,location,staff&fields[location]=city,country&fields[staff_member]=first_name,specialities&page[limit]=5
```
In the above example, `location` and `staff_member` are nested object
types of `location` and `staff` fields respectively.

### How
- Resolve the nested fields while building OpenDD query IR for a
json:api request.
- During planning, always resolve nested selection, if exists, instead
of selecting all available fields from the nested type. (This is only
applicable for model selection, the commands are still using older
approach for nested fields. This will be fixed in the future
iterations).
- Resolve sub-selections of graphql fields in opendd pipeline. Related
test snaps are corrected.
- Include sparse fieldset parameters for nested types in the openapi
schema
<!-- How is it trying to accomplish it (what are the implementation
steps)? -->
V3_GIT_ORIGIN_REV_ID: 587eecb79b6b8fac45f2eb6ffb37bf5fdcc7e374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/console Related to console k/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants