这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@rakeshkky
Copy link
Member

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

closes #51 , #144 , #1090 & #1195

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

Add env vars for '--tx-iso', '--stripes', '--timeout' and '--root-dir'
options
Resolve Conflicts:
	server/src-exec/Main.hs
	server/src-lib/Hasura/Server/Init.hs
@rakeshkky rakeshkky added s/ok-to-merge Status: This pull request can be merged to master c/server Related to server labels Dec 13, 2018
@rakeshkky rakeshkky self-assigned this Dec 13, 2018
@rakeshkky rakeshkky requested a review from 0x777 December 13, 2018 08:41
@hasura-bot
Copy link
Contributor

Review app for commit ff4b50e deployed to Heroku: https://hge-ci-pull-1200.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1200-ff4b50e

@0x777 0x777 requested a review from ecthiender December 13, 2018 09:48
@hasura-bot
Copy link
Contributor

Review app for commit c5931b8 deployed to Heroku: https://hge-ci-pull-1200.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1200-c5931b8

Copy link
Contributor

@ecthiender ecthiender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasura-bot
Copy link
Contributor

Review app for commit b476ea9 deployed to Heroku: https://hge-ci-pull-1200.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1200-b476ea9

@0x777 0x777 merged commit 708a29f into hasura:master Dec 14, 2018
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1200.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Oct 3, 2024
<!-- The PR description should answer 2 important questions: -->

### What

<!-- What is this PR trying to accomplish (and why, if it's not
obvious)? -->

<!-- Consider: do we need to add a changelog entry? -->

<!-- Does this PR introduce new validation that might break old builds?
-->

<!-- Consider: do we need to put new checks behind a flag? -->
Earlier, for pre-response plugins, a span is emitted for each plugin
execution. This PR wraps all plugin executions in a new span that
extends the client headers as parent context.

Before:

![main_pre_resp_plugins](https://github.com/user-attachments/assets/a3d74498-3f56-48fc-becf-a04b814aee4c)
After:

![refactors_pre_resp_plugins](https://github.com/user-attachments/assets/9277327f-a8de-419c-8423-e662ae09c3b0)

Note: `pre_response_plugins_execute` span name renamed to
`execute_all_pre_response_plugins` in later commits.
### How

<!-- How is it trying to accomplish it (what are the implementation
steps)? -->
Move execution of pre-response plugins in a task, into a new function.
Create a span that wraps a function that executes all plugins async.

V3_GIT_ORIGIN_REV_ID: a1febecf4b429e1441e4b53a9b32f39519a12ba9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/server Related to server s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add a version command

4 participants