-
Notifications
You must be signed in to change notification settings - Fork 2.8k
refactor server cli code, add more cli options & version command (close #51, #144, #1090, #1195) #1200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add env vars for '--tx-iso', '--stripes', '--timeout' and '--root-dir' options
Resolve Conflicts: server/src-exec/Main.hs server/src-lib/Hasura/Server/Init.hs
|
Review app for commit ff4b50e deployed to Heroku: https://hge-ci-pull-1200.herokuapp.com |
|
Review app for commit c5931b8 deployed to Heroku: https://hge-ci-pull-1200.herokuapp.com |
ecthiender
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Review app for commit b476ea9 deployed to Heroku: https://hge-ci-pull-1200.herokuapp.com |
|
Review app https://hge-ci-pull-1200.herokuapp.com is deleted |
<!-- The PR description should answer 2 important questions: --> ### What <!-- What is this PR trying to accomplish (and why, if it's not obvious)? --> <!-- Consider: do we need to add a changelog entry? --> <!-- Does this PR introduce new validation that might break old builds? --> <!-- Consider: do we need to put new checks behind a flag? --> Earlier, for pre-response plugins, a span is emitted for each plugin execution. This PR wraps all plugin executions in a new span that extends the client headers as parent context. Before:  After:  Note: `pre_response_plugins_execute` span name renamed to `execute_all_pre_response_plugins` in later commits. ### How <!-- How is it trying to accomplish it (what are the implementation steps)? --> Move execution of pre-response plugins in a task, into a new function. Create a span that wraps a function that executes all plugins async. V3_GIT_ORIGIN_REV_ID: a1febecf4b429e1441e4b53a9b32f39519a12ba9
Description
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
closes #51 , #144 , #1090 & #1195
Solution and Design
Type
Checklist: