server: metadata separation: cleanup schema generation #6116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit 4b66dbf |
CHANGELOG.md
Outdated
| - server: fix issue with tracking custom functions that return `SETOF` materialized view (close #5294) (#5945) | ||
| - server: introduce optional custom table name in table configuration to track the table according to the custom name. The `set_table_custom_fields` API has been deprecated, A new API `set_table_customization` has been added to set the configuration. (#3811) | ||
| - server: allow remote relationships with union, interface and enum type fields as well (fixes #5875) (#6080) | ||
| - server: clean up the post-PDV schema generation (#6116) |
Contributor
There was a problem hiding this comment.
I feel we do not need a changelog for this as it is kinda vague and definitely not user understandable.
Contributor
Author
There was a problem hiding this comment.
Perfect. I was on the fence myself.
0x777
approved these changes
Nov 3, 2020
Member
0x777
left a comment
There was a problem hiding this comment.
I'm not a big fan of how we check for remote schema field conflicts with those derived from tracking tables/functions. We can however defer this to later.
0x777
reviewed
Nov 3, 2020
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
6 tasks
scriptonist
pushed a commit
to scriptonist/graphql-engine
that referenced
this pull request
Nov 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an incremental PR towards #5797. As part of that work, the post-PDV schema generation was improved, in an attempt to improve efficiency of server startup and schema reloading. This PR is a rebase of commit be84310 onto master so that it can hopefully be merged separately.
Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR. If no changelog is required, then add theno-changelog-requiredlabel.Affected components
Related Issues
Solution and Design
Steps to test and verify
Limitations, known bugs & workarounds
Server checklist
Catalog upgrade
Does this PR change Hasura Catalog version?
Metadata
Does this PR add a new Metadata feature?
GraphQL
Breaking changes