-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
events: initial implementation of core simulation components #1008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
597f8fd to
a5c5fb6
Compare
35d1fe4 to
d2d9d0b
Compare
zuntrax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some stuff needs to be cleaned up.
libopenage/curve/continuous.h
Outdated
|
|
||
| template <typename T> | ||
| T Continuous<T>::get(const time_t &time) const { | ||
| const auto& e = this->container.last(time, this->last_element); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto &e?
libopenage/curve/datastream.cpp
Outdated
| @@ -0,0 +1,152 @@ | |||
| // Copyright 2017-2018 the openage authors. See copying.md for legal info. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit later, not used yet.
libopenage/curve/datastream.h
Outdated
| @@ -0,0 +1,62 @@ | |||
| // Copyright 2017-2018 the openage authors. See copying.md for legal info. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit later, not used yet.
libopenage/curve/map.h
Outdated
|
|
||
| /** | ||
| * Map that keeps track of the lifetime of the contained elements. | ||
| * make shure, that no key is never reused. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shure -> sure, double negation
libopenage/curve/map.h
Outdated
| dead(d) {} | ||
| }; | ||
|
|
||
| /** the magic is inside here */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope
libopenage/curve/queue.h
Outdated
| public: | ||
| typedef typename std::deque<queue_wrapper> container_t; | ||
| typedef typename container_t::const_iterator const_iterator; | ||
| typedef typename container_t::const_iterator iterator; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using?
| typename container_t> | ||
| class QueueFilterIterator : public CurveIterator<val_t, container_t, typename container_t::const_iterator> { | ||
| public: | ||
| typedef typename container_t::const_iterator const_iterator; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using?
libopenage/curve/map.h
Outdated
| // remove all dead elements before that point in time | ||
| void clean(const time_t &); | ||
|
|
||
| void __attribute__((noinline)) dump() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no longer needed
| /** | ||
| * Debugging method to be used from gcc to understand bugs better. | ||
| */ | ||
| void __attribute__((noinline)) dump() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no __attribute__
libopenage/curve/queue.h
Outdated
|
|
||
| void clean(const time_t &); | ||
|
|
||
| void __attribute__((noinline)) dump() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no __attribute__
Co-authored-by: Jonas Jelten <jj@sft.mx>
This is an extended/improved version of #744.
Contains