这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@TheJJ
Copy link
Member

@TheJJ TheJJ commented May 2, 2018

This is an extended/improved version of #744.

Contains

  • Curve data storage
  • Event queue and scheduling
  • (cancelled for this pull) Networking draft
  • (cancelled for this pull) Gamestate skeleton

@TheJJ TheJJ added nice new thing ☺ A new feature that was not there before lang: c++ Done in C++ code big stuff High-impact changes, mainly foundation work labels May 2, 2018
@TheJJ TheJJ changed the title events: initial implementation of core simulation components [WIP] events: initial implementation of core simulation components May 2, 2018
@TheJJ TheJJ added this to the Event-driven game logic milestone May 2, 2018
@TheJJ TheJJ mentioned this pull request Jun 3, 2018
@TheJJ TheJJ force-pushed the event-core branch 2 times, most recently from 597f8fd to a5c5fb6 Compare June 30, 2018 01:02
@TheJJ TheJJ force-pushed the event-core branch 7 times, most recently from 35d1fe4 to d2d9d0b Compare July 29, 2018 10:14
@TheJJ TheJJ requested review from mic-e and zuntrax July 29, 2018 11:05
Copy link
Contributor

@zuntrax zuntrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some stuff needs to be cleaned up.


template <typename T>
T Continuous<T>::get(const time_t &time) const {
const auto& e = this->container.last(time, this->last_element);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto &e?

@@ -0,0 +1,152 @@
// Copyright 2017-2018 the openage authors. See copying.md for legal info.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit later, not used yet.

@@ -0,0 +1,62 @@
// Copyright 2017-2018 the openage authors. See copying.md for legal info.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit later, not used yet.


/**
* Map that keeps track of the lifetime of the contained elements.
* make shure, that no key is never reused.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shure -> sure, double negation

dead(d) {}
};

/** the magic is inside here */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope

public:
typedef typename std::deque<queue_wrapper> container_t;
typedef typename container_t::const_iterator const_iterator;
typedef typename container_t::const_iterator iterator;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using?

typename container_t>
class QueueFilterIterator : public CurveIterator<val_t, container_t, typename container_t::const_iterator> {
public:
typedef typename container_t::const_iterator const_iterator;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using?

// remove all dead elements before that point in time
void clean(const time_t &);

void __attribute__((noinline)) dump() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer needed

/**
* Debugging method to be used from gcc to understand bugs better.
*/
void __attribute__((noinline)) dump() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no __attribute__


void clean(const time_t &);

void __attribute__((noinline)) dump() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no __attribute__

@TheJJ TheJJ changed the title [WIP] events: initial implementation of core simulation components events: initial implementation of core simulation components Jul 29, 2018
@zuntrax zuntrax merged commit 7f4ea42 into SFTtech:master Jul 29, 2018
@TheJJ TheJJ deleted the event-core branch January 27, 2019 19:48
@heinezen heinezen mentioned this pull request Jun 24, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

big stuff High-impact changes, mainly foundation work lang: c++ Done in C++ code nice new thing ☺ A new feature that was not there before

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants