Initial AWS Serverfull Deployment using Terraform #678
Conversation
sachin-101
left a comment
There was a problem hiding this comment.
Great start. I would suggest to keep all the Terraform files in a directory, as it is the standard practice. We can keep that directory in the root PyGrid folder. May be name the directory deploy.
| cidr_blocks = ["0.0.0.0/0"] | ||
| } | ||
|
|
||
| ingress { |
There was a problem hiding this comment.
We probably want to disable SSH from a security standpoint. Do you need this to be open for some reason?
There was a problem hiding this comment.
I am enabling it to be able to access the instance and make sure PyGrid is working, check logs, etc...
There was a problem hiding this comment.
Basically using it for deployment and development purposes, but yeah we should disable it once we are ready for production
There was a problem hiding this comment.
Let's consider that to be now. Go ahead and remove this. I'd hate to forget about it later.
There was a problem hiding this comment.
I believe we should leave it for now since it's already used for deploy.sh script and provisioner to be executed on the instances
cereallarceny
left a comment
There was a problem hiding this comment.
Nice work @AmrMKayid - really love this. I'd love to even see some tests around this (if possible). Likewise, one thing we'll want to do ASAP is to develop a CLI and API around deploying these changes. That's gonna come in handy once we have the PyGrid Admin ready to go. 😄
| cidr_blocks = ["0.0.0.0/0"] | ||
| } | ||
|
|
||
| ingress { |
There was a problem hiding this comment.
Let's consider that to be now. Go ahead and remove this. I'd hate to forget about it later.
Description
Initial Deployment for Node to serverfull environment on AWS (HTTP and Websockets)
fixes #642
Checklist
Affected Dependencies
Using Terraform for deployment
How has this been tested?
Testing on AWS production
Checklist