fix(API): stop storing multiple custom attributes of same type for Reources #681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ae0da75 to
43ccff6
Compare
43ccff6 to
6122cee
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a bug where the API would create duplicate custom attribute values in the database instead of updating existing ones. The fix simplifies the ChangeAttributes method to use the existing ChangeAttribute method for each attribute, ensuring proper update behavior.
- Replaces complex diff-based logic with simpler per-attribute processing
- Eliminates duplicate custom attribute storage by using the existing
ChangeAttributemethod - Aligns API behavior with web interface behavior for custom attribute updates
6122cee to
05146c0
Compare
…sources When using the API to update a resource it would cause multiple custom attributes with the same ID to be stored in the `custom_attribute_values` table in the database. For example if currently have the custom attribute "Test Number" set to 1 for the resource. And then use the API to change it to a value of 2. In the `custom_attribute_values` table there will now be both entries stored. When using the web interface to edit the custom attribute it will delete the old value from the database table and then add new value. Change it so that the old value will be deleted and the new value added. Closes: #680
05146c0 to
cbed850
Compare
Contributor
Author
|
I tested this using the API on over 1000 records. I read a resource, wrote the resource, and then verified the resource was the same as before. I also checked the SQL database and saw that the extra entries in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the API to update a resource it would cause multiple custom attributes with the same ID to be stored in the
custom_attribute_valuestable in the database.For example if currently have the custom attribute "Test Number" set to 1 for the resource. And then use the API to change it to a value of 2. In the
custom_attribute_valuestable there will now be both entries stored. When using the web interface to edit the custom attribute it will delete the old value from the database table and then add new value.Change it so that the old value will be deleted and the new value added.
Closes: #680