fix(api): prevent duplicate custom attribute values when updating res… #685
Conversation
5bd9979 to
c5f875c
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where updating resources via the API was creating duplicate custom attribute values instead of properly replacing them. The core issue was that BuildResource() created a fresh BookableResource object without existing attributes, preventing ChangeAttributes() from detecting which attributes should be removed.
- Add
GetAttributeValues()method toBookableResourcewith copy protection using spread operator - Modify
BuildResource()to accept an optionalexistingResourceparameter and copy existing attributes before callingChangeAttributes() - Update both
Create()andUpdate()methods to use named parameters for better readability
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
WebServices/Controllers/ResourceSaveController.php |
Modified BuildResource() method to accept existing resource and copy attributes; updated method calls to use named parameters |
Domain/BookableResource.php |
Added GetAttributeValues() method that returns a copy of attribute values array |
| * @return BookableResource | ||
| */ | ||
| private function BuildResource($request, $resourceId) | ||
| private function BuildResource(ResourceRequest $request, int $resourceId, ?BookableResource $existingResource = null): BookableResource |
There was a problem hiding this comment.
The method signature change introduces inconsistency between Create and Update calls. In Create, existingResource will always be null, making the parameter unnecessary. Consider creating a separate method like BuildResourceFromExisting() for the Update case to maintain clearer API semantics.
4c59467 to
76d5145
Compare
…ources
When updating a resource via the API, existing custom attribute values
were not being removed before adding new ones, causing duplicate entries
in the custom_attribute_values table.
The issue occurred because BuildResource() created a fresh BookableResource
object with empty attributes, so ChangeAttributes() couldn't detect which
attributes should be removed.
* Add GetAttributeValues() method to BookableResource with copy
protection
* Copy existing attributes to new resource before calling
ChangeAttributes()
76d5145 to
ad3a01b
Compare
|
I did some testing and this did not work |
…ources
When updating a resource via the API, existing custom attribute values were not being removed before adding new ones, causing duplicate entries in the custom_attribute_values table.
The issue occurred because BuildResource() created a fresh BookableResource object with empty attributes, so ChangeAttributes() couldn't detect which attributes should be removed.