-
Notifications
You must be signed in to change notification settings - Fork 314
Fix date and autogrow issues #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an enormous diff. Can the white-space changes be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the editor used changed the end-of-line characters, which caused the big diff.
Before this PR:
$ file tpl/Reservation/create.tpl
tpl/Reservation/create.tpl: HTML document, ASCII text, with CRLF line terminators
This PR:
$ file tpl/Reservation/create.tpl
tpl/Reservation/create.tpl: HTML document, ASCII text
I need to work on doing a complete reformat of the code as one commit, so this stops happening... Related is #626
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used unix2dos to convert it back and repushed.
JohnVillalovos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucs7 Thanks.
Overall looks good to me except for the one file with all the white-space changes. Unsure if there is an actual change in there. I can't tell.
a54dac8 to
42e0f51
Compare
JohnVillalovos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lucs7 Thanks again!
Bug in UTC conversion caused dates to be off by one day for UTC+n locales fixed by direct date parsing from PHP. Closes: LibreBooking#657
|
FYI: I updated the commit messages with the descriptions from the PR. |
Bug in UTC conversion caused dates to be off by one day for UTC+n locales fixed by direct date parsing from PHP. Closes: LibreBooking#651
Removed old autogrow dependency not in use anymore but causing console error.
Uh oh!
There was an error while loading. Please reload this page.