这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@lucs7
Copy link
Contributor

@lucs7 lucs7 commented Jul 6, 2025

  1. fix(datepicker): prevent one-day offset caused by UTC conversion Wrong input date on reservation edit #651
  • bug in UTC conversion caused dates to be off by one day for UTC+n locales
  • fixed by direct date parsing from PHP
  1. fix(autogrow): removed unused dependency replaced by Bootstrap
  • removed old autogrow dependency not in use anymore but causing console error

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an enormous diff. Can the white-space changes be removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the editor used changed the end-of-line characters, which caused the big diff.

Before this PR:

$ file tpl/Reservation/create.tpl
tpl/Reservation/create.tpl: HTML document, ASCII text, with CRLF line terminators

This PR:

$ file tpl/Reservation/create.tpl
tpl/Reservation/create.tpl: HTML document, ASCII text

I need to work on doing a complete reformat of the code as one commit, so this stops happening... Related is #626

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used unix2dos to convert it back and repushed.

Copy link
Contributor

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucs7 Thanks.

Overall looks good to me except for the one file with all the white-space changes. Unsure if there is an actual change in there. I can't tell.

@lucs7 lucs7 force-pushed the develop branch 2 times, most recently from a54dac8 to 42e0f51 Compare July 6, 2025 16:42
Copy link
Contributor

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucs7 Thanks again!

JohnVillalovos pushed a commit to lucs7/librebooking that referenced this pull request Jul 6, 2025
Bug in UTC conversion caused dates to be off by one day for UTC+n
locales fixed by direct date parsing from PHP.

Closes: LibreBooking#657
@JohnVillalovos
Copy link
Contributor

FYI: I updated the commit messages with the descriptions from the PR.

lucs7 added 2 commits July 6, 2025 10:28
Bug in UTC conversion caused dates to be off by one day for UTC+n
locales fixed by direct date parsing from PHP.

Closes: LibreBooking#651
Removed old autogrow dependency not in use anymore but causing console
error.
@JohnVillalovos JohnVillalovos merged commit 6fb8c73 into LibreBooking:develop Jul 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants