这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@alice
Copy link
Member

@alice alice commented Dec 12, 2017

@robdodson PTAL - will wait for w3c/csswg-drafts#2104 to go in obviously.

Also, after this will need to do a major release and rename the repo and NPM module.

@robdodson
Copy link
Collaborator

I think it might be useful for the README to have a note somewhere that this was originally called :focus-ring but renamed to :focus-visible. We've already done a fair amount of devrelling telling folks about :focus-ring so anything we can do to migrate people's thoughts will be useful.

@robdodson
Copy link
Collaborator

robdodson commented Dec 12, 2017

oh hm... we're also going to need to npm deprecate wicg-focus-ring and publish a new project, wicg-focus-visible.

Also, these projects would need to update:

Possibly others...?

@robdodson
Copy link
Collaborator

Sorry I see that you commented that we need to rename the repo and npm module. I don't think you can actually rename an npm dependency. You have to deprecate it which logs a warning when people install, then you have to publish a different one.

@nicolasparada nicolasparada mentioned this pull request Dec 27, 2017
@ryuran
Copy link

ryuran commented Dec 28, 2017

@robdodson you're right. Rename the npm package is not possible but we can deprecate it and register this new version with a new name.

@joe-watkins
Copy link

FF team in the know on this? moz-focusring https://caniuse.com/#search=focus-ring

@robdodson
Copy link
Collaborator

@joe-watkins yeah we've spoken with them about this.

@robdodson
Copy link
Collaborator

oh sorry! you mean are they aware of the name change (I thought you were asking if they're aware that this WICG repo exists). That's actually a good question, I'll ping them to make sure they've seen it.

@robdodson
Copy link
Collaborator

Also I'm going to see about renaming this polyfill at the end of this week, hopefully rolling it out Friday or even Saturday so we don't break anyone and we have some space to deal with all the npm stuff.

@robdodson robdodson merged commit 2b64c11 into WICG:master Jan 12, 2018
robinwhittleton added a commit to robinwhittleton/caniuse that referenced this pull request Jan 20, 2018
robinwhittleton added a commit to robinwhittleton/caniuse that referenced this pull request Jan 20, 2018
robinwhittleton added a commit to robinwhittleton/caniuse that referenced this pull request Jan 20, 2018
robinwhittleton added a commit to robinwhittleton/caniuse that referenced this pull request Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants