-
Notifications
You must be signed in to change notification settings - Fork 124
Rename :focus-ring to :focus-visible #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think it might be useful for the README to have a note somewhere that this was originally called |
|
oh hm... we're also going to need to npm deprecate wicg-focus-ring and publish a new project, wicg-focus-visible. Also, these projects would need to update: Possibly others...? |
|
Sorry I see that you commented that we need to rename the repo and npm module. I don't think you can actually rename an npm dependency. You have to deprecate it which logs a warning when people install, then you have to publish a different one. |
|
@robdodson you're right. Rename the npm package is not possible but we can deprecate it and register this new version with a new name. |
|
FF team in the know on this? |
|
@joe-watkins yeah we've spoken with them about this. |
|
oh sorry! you mean are they aware of the name change (I thought you were asking if they're aware that this WICG repo exists). That's actually a good question, I'll ping them to make sure they've seen it. |
|
Also I'm going to see about renaming this polyfill at the end of this week, hopefully rolling it out Friday or even Saturday so we don't break anyone and we have some space to deal with all the npm stuff. |
This was changed in draft: WICG/focus-visible#90
This was changed in draft: WICG/focus-visible#90
This was changed in draft: WICG/focus-visible#90
This was changed in draft: WICG/focus-visible#90
@robdodson PTAL - will wait for w3c/csswg-drafts#2104 to go in obviously.
Also, after this will need to do a major release and rename the repo and NPM module.