Assign config instance during navigation #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtanzer
approved these changes
May 22, 2023
75f5b8c to
2d74daf
Compare
github-actions bot
added a commit
that referenced
this pull request
May 22, 2023
SHA: f3d2d23 Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on
[=browsing context/fenced frame config instance=](instead of the current spec's[=navigable/fenced frame config instance=]), as introduced in #90. Even though this PR only references that term editorially, until that PR is merged this build will fail.This PR does not yet assign the browsing context's fenced frame config instance. A subsequent PR will do this in the document creation algorithm by pulling the config instance off of the navigation params, whose member is introduced by this PR, and placing it on the browsing context that loads inside the fenced frame.
Preview | Diff