Move fenced frame config instance to browsing context #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8e3a740 to
bed6c95
Compare
gtanzer
reviewed
May 22, 2023
gtanzer
approved these changes
May 22, 2023
Collaborator
gtanzer
left a comment
There was a problem hiding this comment.
LGTM % question on BC vs BCG
github-actions bot
added a commit
that referenced
this pull request
May 22, 2023
SHA: 4c31118 Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial follow-up to the discussion in #84 (comment). All this does is move the fenced frame config instance from navigable => browsing context, and updates the advisement text around it and all usages.
A follow-up to this will finalize the config instance assignment to happen at the time where a new browsing context group is chosen for the fenced frame for embedder-initiated navigations, so that the config instance is always wiped.
Preview | Diff