这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@gtanzer
Copy link
Collaborator

@gtanzer gtanzer commented Sep 6, 2023

@gtanzer gtanzer requested a review from domfarolino September 6, 2023 18:44
spec.bs Outdated
[=node navigable=]'s [=navigable/traversable navigable=]'s
[=traversable navigable/fenced frame config mapping=].

1. Let |config| be the result of [=fenced frame config mapping/finding a config=] in |mapping|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems wrong to do this synchronously, and seems to not match what the implementation does, since the implementation does this "in parallel" and returns a promise.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I should make this a promise...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turned this into a promise, modeling after some parts of the Protected Audience spec. Lmk if it I didn't do it right.

</div>

To help with ease of adoption,
[until 2026](https://github.com/WICG/turtledove/issues/286#issuecomment-1682842636) we will support
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes it sound like we're actually indeed removing the API in 2026. Are we? Or are we just "deprecating" it softly then?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been deprecated since it was added, hence the name. It should actually be removed in several years.

@domfarolino domfarolino merged commit 3b93e20 into master Sep 22, 2023
@domfarolino domfarolino deleted the deprecated-replace-in-urn branch September 22, 2023 14:39
github-actions bot added a commit that referenced this pull request Sep 22, 2023
SHA: 3b93e20
Reason: push, by domfarolino

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants