这是indexloc提供的服务，不要输入任何密码
Skip to content

Spec reportEvent to custom destination URLs with macro substitution #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Sep 28, 2023
Merged

Spec reportEvent to custom destination URLs with macro substitution #113

merged 16 commits into from
Sep 28, 2023

Conversation

@gtanzer
Copy link
Collaborator

@gtanzer gtanzer commented Aug 23, 2023 •
edited by pr-preview bot
Loading

gtanzer
gtanzer commented Aug 23, 2023
View reviewed changes
@gtanzer gtanzer requested a review from domfarolino August 23, 2023 22:36
qingxinwu
qingxinwu reviewed Aug 24, 2023
View reviewed changes
@shivanigithub shivanigithub mentioned this pull request Aug 25, 2023
Closed
1 task
@gtanzer
Copy link
Collaborator Author

gtanzer commented Aug 29, 2023

@qingxinwu Thanks for reviewing! Fixed all the comments.

domfarolino
domfarolino reviewed Aug 31, 2023
View reviewed changes
@gtanzer
Copy link
Collaborator Author

gtanzer commented Sep 6, 2023

To be merged after #117 , which creates [=fencedframeutil/substitute macros=].

@domfarolino
Copy link
Collaborator

domfarolino commented Sep 8, 2023

To be merged after #117 , which creates [=fencedframeutil/substitute macros=].

Sounds good, I think this mostly looks good so let's wait until that gets landed then.

domfarolino
domfarolino approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qingxinwu Does this look good to you?

qingxinwu
qingxinwu reviewed Sep 26, 2023
View reviewed changes
@qingxinwu
Copy link

qingxinwu commented Sep 26, 2023

LGTM.

@gtanzer gtanzer merged commit 2ecd14a into master Sep 28, 2023
@gtanzer gtanzer deleted the macro-substitution branch September 28, 2023 13:19
github-actions bot added a commit that referenced this pull request Sep 28, 2023
@gtanzer @github-actions
Spec reportEvent to custom destination URLs with macro substitution (#…
1b8adec 
…113)

SHA: 2ecd14a
Reason: push, by gtanzer

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domfarolino domfarolino domfarolino approved these changes

+1 more reviewer

@qingxinwu qingxinwu qingxinwu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gtanzer @domfarolino @qingxinwu