Fix spec build failure due to visibilities ref #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VergeA
approved these changes
Feb 24, 2025
Collaborator
VergeA
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this!
Collaborator
Author
|
+domfarolino to take a look, thanks! |
github-actions bot
added a commit
that referenced
this pull request
Feb 24, 2025
SHA: fa4ec2c Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix spec build failure #211
The current
[=visibilities=]is referencing https://www.w3.org/TR/CSS22/visufx.html#propdef-visibility, which is incorrect.It should be
[=fencedframeconfig/visibilities=]which references:fenced-frame/spec.bs
Lines 793 to 794 in 6fa197f
Also add the reference to the other "visibilities" in the spec.
Preview | Diff