这是indexloc提供的服务,不要输入任何密码
Skip to content

Fix spec build failure due to visibilities ref #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 24, 2025

Conversation

xiaochen-z
Copy link
Collaborator

@xiaochen-z xiaochen-z commented Feb 24, 2025

Fix spec build failure #211

The current [=visibilities=] is referencing https://www.w3.org/TR/CSS22/visufx.html#propdef-visibility, which is incorrect.

It should be [=fencedframeconfig/visibilities=] which references:

fenced-frame/spec.bs

Lines 793 to 794 in 6fa197f

A <dfn export for=fencedframeconfig>visibility</dfn> is either "<dfn export
for=visibility>`opaque`</dfn>" or "<dfn export for=visibility>`transparent`</dfn>".

Also add the reference to the other "visibilities" in the spec.


Preview | Diff

@VergeA VergeA self-requested a review February 24, 2025 15:38
Copy link
Collaborator

@VergeA VergeA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@xiaochen-z
Copy link
Collaborator Author

+domfarolino to take a look, thanks!

@domfarolino domfarolino merged commit fa4ec2c into WICG:master Feb 24, 2025
2 checks passed
github-actions bot added a commit that referenced this pull request Feb 24, 2025
SHA: fa4ec2c
Reason: push, by domfarolino

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@xiaochen-z xiaochen-z deleted the fix_visibilities_ref branch February 25, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants