这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@JonnyBurger
Copy link
Contributor

@JonnyBurger JonnyBurger commented Nov 6, 2025

Adds rotation property from WebCodecs Spec: w3.org/TR/webcodecs#dom-videoframeinit-rotation

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@JonnyBurger JonnyBurger changed the title @types/dom-webcodecs: Add rotation and flip to VideoFrameInit @types/dom-webcodecs: Add rotation to VideoFrameInit Nov 6, 2025
@typescript-bot
Copy link
Contributor

typescript-bot commented Nov 6, 2025

@JonnyBurger Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 9 days.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 74027,
  "author": "JonnyBurger",
  "headCommitOid": "f17ea2667c088b87f66e7dc75e59d024c0428598",
  "mergeBaseOid": "2243b87255f228f1052ba457c4eaed37dce55047",
  "lastPushDate": "2025-11-06T12:57:21.000Z",
  "lastActivityDate": "2025-11-06T12:57:21.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "dom-webcodecs",
      "kind": "edit",
      "files": [
        {
          "path": "types/dom-webcodecs/webcodecs.generated.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "dogben"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 3497151197,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels Nov 6, 2025
@typescript-bot
Copy link
Contributor

Hey @JonnyBurger,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Nov 6, 2025
@typescript-bot
Copy link
Contributor

🔔 @dogben — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests

Projects

Status: Needs Maintainer Review

Development

Successfully merging this pull request may close these issues.

2 participants