-
Notifications
You must be signed in to change notification settings - Fork 30.5k
@types/dom-webcodecs: Add rotation to VideoFrameInit
#74027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@types/dom-webcodecs: Add rotation and flip to VideoFrameInit@types/dom-webcodecs: Add rotation to VideoFrameInit
|
@JonnyBurger Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 11 days — please try to get reviewers! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 74027,
"author": "JonnyBurger",
"headCommitOid": "f17ea2667c088b87f66e7dc75e59d024c0428598",
"mergeBaseOid": "2243b87255f228f1052ba457c4eaed37dce55047",
"lastPushDate": "2025-11-06T12:57:21.000Z",
"lastActivityDate": "2025-11-06T12:57:21.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "dom-webcodecs",
"kind": "edit",
"files": [
{
"path": "types/dom-webcodecs/webcodecs.generated.d.ts",
"kind": "definition"
}
],
"owners": [
"dogben"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [],
"mainBotCommentID": 3497151197,
"ciResult": "pass"
} |
|
Hey @JonnyBurger, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
|
🔔 @dogben — please review this PR in the next few days. Be sure to explicitly select |
|
Re-ping @dogben: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
Adds
rotationproperty from WebCodecs Spec: w3.org/TR/webcodecs#dom-videoframeinit-rotationPlease fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.If changing an existing definition:
package.json.If removing a declaration:
notNeededPackages.json.