Slightly unexpected, but I don't know why code in packages was not aligned with configured tool for code styling. In my setup, when formatting is applied on every Ctrl+S it leads to massive changes and huge git diff. So fixing style issue and will add more PR's later

Thank you very much @wermanoid for your PullRequest.

I will merge this PullRequest before #1410 and also this one before #1402.

It may impact your PullRequest.

I will keep it up-to-date, so merge anything that is needed :) no problems

Btw, maybe it worth also to check prettier config too? Tbh, this is first time when I see that someone is using tab keys for indentation. Usually it is 2 or 4 whitespaces.

If you don't mind, I can change to this:

  printWidth: 100,
  tabWidth: 2,
  trailingComma: 'all',
  arrowParens: 'avoid',
  endOfLine: 'auto',
  bracketSameLine: false,
  bracketSpacing: true,
  singleQuote: true,
  useTabs: false,
  semi: true,

@wermanoid I would suggest reviewing the prettier config to align to the existing project source, and agree tab should be replaced with whatever the most common existing pattern is in the project, which appears to be 2 spaces not tab.

i.e. treat the project's existing approach as preferred and adjust prettierrc to conform, vs prettier being the point of truth now.
I think I may of added prettier as a placeholder a ways back, and not correctly aligned to project style.

Also, there appears to be a disconnect between ESlint running prettier rules and running prettier externally. Ideally, ESlint should be reading the prettier config and if request autofix with eslint --fix . So I think there is something amiss with the eslint-> prettier config. I did a PR to migrate to ESLint 9 flat config style, so probably have something misconfigured.

@guillaume-chervet does this sound ok?

@wermanoid @guillaume-chervet
I found the issue with eslint not running prettier. If you commit #1419 it will ensure eslint runs prettier.
I haven't made changes to prettier config or applied the prettier autofix, as this is what this PR is for.
pnpm run lint will now show the prettier issues.
pnpm run lint --fix will autofix them

Updated after all eslint fixes
@jafin @guillaume-chervet , I've modified config to proposed upper and applied that to whole repo (pnpm format in scripts actually).

Also, do I need to fix TS errors that prevents pipeline to pass? Or better to make that as another PR?

@jafin I do not code a lot in Javascript/typescript these days (unfortunately).

This configuration seems OK to you?