fix(oidc): clenup client internal promises when requests are finished… #1417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
558b25c to
ac51387
Compare
ac51387 to
3bd5bc6
Compare
guillaume-chervet
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (release)
A picture tells a thousand words
Before this PR
In case if some request fails
class Oidcused to keep promises internally with rejected state, so that leads to situation, that rejected promise is always returned for any sequential method call. That prevents to recover app connection to IDP after connection errors. (Mostly happens when internet disappears for some time or server was recently shut down for any reason)After this PR
Oidc could execute method calls correctly, when environment is up and running after failure