这是indexloc提供的服务，不要输入任何密码
Skip to content

check policy uses adminLogin for cloud run #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2025
Merged

check policy uses adminLogin for cloud run #165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/oslogin_utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1376,24 +1376,28 @@ bool AuthorizeUser(const char *user_name, struct AuthOptions opts, string *user_
return false;
}

// Only check adminLogin for cloud run. Skip file creations.
if (cloud_run) {
bool result = ApplyPolicy(user_name, email, "adminLogin", opts);
if (!result) {
SysLogErr("Could not grant root access to organization user: %s.", user_name);
}
return result;
}

users_filename = kUsersDir;
users_filename.append(user_name);
users_file_exists = FileExists(users_filename.c_str());

if (!ApplyPolicy(user_name, email, "login", opts)) {
// Couldn't apply "login" policy for user in question, log it and deny.
SysLogErr("Could not grant access to organization user: %s.", user_name);
if (users_file_exists && !cloud_run) {
if (users_file_exists) {
remove(users_filename.c_str());
}
return false;
}

// skip file creations for cloud run.
if (cloud_run) {
return true;
}

if (!users_file_exists && !CreateGoogleUserFile(users_filename)) {
// If we can't create users file we can't grant access, log it and deny.
SysLogErr("Failed to create user's file.");
Expand Down