这是indexloc提供的服务，不要输入任何密码
Skip to content

check policy uses adminLogin for cloud run #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2025
Merged

check policy uses adminLogin for cloud run #165

merged 1 commit into from
Aug 8, 2025
+10 −6

Conversation

@coolheavynest
Copy link
Contributor

@coolheavynest coolheavynest commented Aug 7, 2025

As discussed before, cloud run will check adminLogin instead.

@google-oss-prow
Copy link

google-oss-prow bot commented Aug 7, 2025

Hi @coolheavynest. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ChaitanyaKulkarni28
Copy link
Member

ChaitanyaKulkarni28 commented Aug 7, 2025

/ok-to-test

ericdand
ericdand approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@ericdand ericdand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Aug 8, 2025
@google-oss-prow
Copy link

google-oss-prow bot commented Aug 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coolheavynest, ericdand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit bdce7ee into GoogleCloudPlatform:master Aug 8, 2025
4 checks passed
ericdand pushed a commit to ericdand/guest-oslogin that referenced this pull request Oct 21, 2025
@coolheavynest @ericdand
check policy uses adminLogin for cloud run (GoogleCloudPlatform#165)
c51d8c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChaitanyaKulkarni28 ChaitanyaKulkarni28 Awaiting requested review from ChaitanyaKulkarni28

@jjerger jjerger Awaiting requested review from jjerger

1 more reviewer

@ericdand ericdand ericdand approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ericdand ericdand

Labels

approved lgtm ok-to-test size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coolheavynest @ChaitanyaKulkarni28 @ericdand