这是indexloc提供的服务，不要输入任何密码
Skip to content

perf: use initializer instead of late initialization and polymorph getters #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf: use initializer instead of late initialization and polymorph getters #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 9 additions & 13 deletions packages/talker/lib/src/models/talker_data.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,13 @@ class TalkerData {
DateTime? time,
this.pen,
this.key,
}) {
_time = time ?? DateTime.now();
}

late DateTime _time;
}) : time = time ?? DateTime.now();

/// {@template talker_data_message}
/// [String] [message] - message describes what happened
/// {@endtemplate}
final String? message;

final String? key;

/// {@template talker_data_loglevel}
/// [LogLevel] [logLevel] - to control logging output
/// {@endtemplate}
Expand All @@ -42,24 +36,26 @@ class TalkerData {
/// {@endtemplate}
final Error? error;

/// {@template talker_data_title}
/// Title of Talker log
/// {@endtemplate}
String? title;

/// {@template talker_data_stackTrace}
/// StackTrace?] [stackTrace] - stackTrace if [exception] or [error] happened
/// {@endtemplate}
final StackTrace? stackTrace;

/// {@template talker_data_title}
/// Title of Talker log
/// {@endtemplate}
String? title;

/// {@template talker_data_time}
/// Internal time when the log occurred
/// {@endtemplate}
DateTime get time => _time;
final DateTime time;

/// [AnsiPen?] [pen] - sets your own log color for console
AnsiPen? pen;

final String? key;

/// {@template talker_data_generateTextMessage}
/// Internal method that generates
/// a complete message about the event
Expand Down
19 changes: 6 additions & 13 deletions packages/talker/lib/src/models/talker_error.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,12 @@ class TalkerError extends TalkerData {
String? key,
super.title,
LogLevel? logLevel,
}) : super(message, error: error) {
_key = key ?? TalkerLogType.error.key;
_logLevel = logLevel ?? LogLevel.error;
}

late String _key;
late LogLevel _logLevel;

@override
String get key => _key;

@override
LogLevel? get logLevel => _logLevel;
}) : super(
message,
logLevel: logLevel ?? LogLevel.error,
error: error,
key: key ?? TalkerLogType.error.key,
);

/// {@macro talker_data_generateTextMessage}
@override
Expand Down
21 changes: 7 additions & 14 deletions packages/talker/lib/src/models/talker_exception.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import 'package:talker/talker.dart';

/// Base implementation of [TalkerData]
/// to handle ONLY [Exceptions]s
/// to handle ONLY [Exception]s
class TalkerException extends TalkerData {
TalkerException(
Exception exception, {
Expand All @@ -10,19 +10,12 @@ class TalkerException extends TalkerData {
String? key,
super.title,
LogLevel? logLevel,
}) : super(message, exception: exception) {
_key = key ?? TalkerLogType.exception.key;
_logLevel = logLevel ?? LogLevel.error;
}

late String _key;
late LogLevel _logLevel;

@override
String get key => _key;

@override
LogLevel? get logLevel => _logLevel;
}) : super(
message,
logLevel: logLevel ?? LogLevel.error,
exception: exception,
key: key ?? TalkerLogType.exception.key,
);

/// {@macro talker_data_generateTextMessage}
@override
Expand Down